Clojurians Log v2
Clojure programming
Channels
Apps
portal
grahamcarlyle 2023-02-16T13:59:58.060149Z
When I was first setting up portal and shadow using the guide I wasn't initially clear that the code required me to create a portal.setup namespace to be referred in the shadow :devtools :preloads config. I wonder if it would be better for the guide to suggest a config using the available portal.shadow.preload namespace as a preload to get started? e.g.
:build-hooks [(portal.shadow.remote/hook)]
:devtools {:preloads [portal.shadow.preload]}grahamcarlyle 2023-02-28T09:43:18.229699Z
I've reverted those changes in the PR, and tried again with just some updates to the docs. In the guide I defaulted the config to the existing namespace just because that seems the quickest way to get going, and also tweaked the examples to have namespaces that emphasise they aren't part of portal code. Feel free to ignore this though as this is just addressing a small bit of friction I felt.
❤️ 1
djblue 2023-02-28T16:44:52.794629Z
Every bit of friction reduced is a win, thanks 🙏
👍 1
djblue 2023-02-16T20:21:41.401729Z
Good point, would you like to submit a PR with the proposed change?
grahamcarlyle 2023-02-27T14:20:18.946799Z
I've submitted a PR https://github.com/djblue/portal/pull/167
djblue 2023-02-27T18:10:52.543809Z
I think I lean more towards clarifying that the user needs to create these namespaces than providing examples from the portal library code. As soon as people can pull it in, it becomes part of the api surface area of portal which I want to keep small.