portal 2022-11-10 | Slack Archive

djblue04:11:23

https://djblue.github.io/portal/?content-url=https://gist.githubusercontent.com/djblue/818b311c3706f565b95a649d35cdb128/raw/09ddf9cb31efc2f17846bd673ab06da00934078f/docs.clj&content-type=application/edn

👍 3

🔥 4

djblue04:11:55

Make sure to try relative selection / expand + collapse / copy + paste 🔥

dumrat05:11:01

wow cool

djblue05:11:59

Best part is that the docs are "just data" so they can be treated like all other data in portal.

dumrat07:11:35

Where is the data for the docs? And how can I use portal for something similar. I've been thinking of can I expose portal as part of my app 😄. Might be useful

djblue07:11:26

The data is hosted via a github gist and being loaded like https://cljdoc.org/d/djblue/portal/0.33.0/doc/guides/portal-standalone#preloading-data. You can select the root value and change the viewer to get a sense of what the underlying data looks like 👌

👍 1

walterl11:11:43

I've definitely stealing https://github.com/djblue/portal/blob/master/dev/tasks/tools.clj for use in future projects 😍

djblue15:11:04

https://djblue.github.io/portal/?content-url=https://gist.githubusercontent.com/djblue/9a2cd250e061f62ce527b20648fd8256/raw/e7bd673df60b3c503306956b950bb9589ba480eb/data.clj&content-type=application/edn is what the build output looks like in portal

dangercoder11:11:19

I'm using table mode and filtering on a column. How can I remove the highlighting? (All rows turns grey).

djblue16:11:06

There currently isn't an option to disable. It should be relatively easy to add https://github.com/djblue/portal/blob/master/src/portal/ui/inspector.cljs#L266. One option is to toggle dimming, but if it's hurting readability, maybe it should stop dimming and only highlight what's matched :thinking_face:

dangercoder19:11:44

Hey, thanks for the reply. Yeah the problem for me was that I found it harder to read

djblue19:11:44

👍 thanks for the feedback

djblue04:11:42

https://github.com/djblue/portal/commit/97d793083936fa6ecf89515327f7c0661d8f0c01 should fix the readability issue 👍

⭐ 1

rschmukler20:11:48

Hey all! Thought I would share a recent debugging experience. I had a collection that wasn't rendering correctly. PS. Love the tool - it has become almost essential for one of the projects I am working on. If I called (tap> (take 1 coll)) I got something that looks like the attached screen shot If I then called portal/clear and call (tap> (take 1 coll)) it worked fine. Later I found this to something to do with one of the entries crashing the portal/submit Further investigation reveals that the issue is that it can't handle a map with ##Inf in it. All in all some logging or throwing of errors might be worth considering rather than silently failing

djblue21:11:55

Thanks for the kind words! This is probably related to using json at the bottom for serialization. Might need to add this as a special case when serializing numbers. I already have to do https://github.com/djblue/portal/blob/master/src/portal/runtime/cson.cljc#L31-L37. Sounds like portal needs special handling for ##Inf, probably https://github.com/djblue/portal/blob/master/src/portal/runtime/cson.cljc#L52-L55 :thinking_face:

djblue21:11:24

Want to give it a shot?

djblue21:11:18

https://github.com/cognitect/transit-js/blob/master/src/com/cognitect/transit/types.js#L1257-L1269 is how transit does it. Unfortunately, portal had to stop using transit for serialization due to transitive dependency version conflicts 😢

rschmukler21:11:39

That's too bad indeed 😞

rschmukler21:11:59

Yeah happy to contribute. Probably won't have time until tomorrow 🙂

🙏 1

rschmukler21:11:44

I'll probably throw ##NaN support in the same PR if that's okay

💯 2