This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2022-08-30
Channels
- # announcements (12)
- # babashka (25)
- # biff (30)
- # cherry (34)
- # cider (46)
- # clj-kondo (23)
- # clojure (37)
- # clojure-berlin (6)
- # clojure-europe (12)
- # clojure-nl (4)
- # clojure-norway (6)
- # clojure-uk (2)
- # clojurescript (8)
- # conjure (1)
- # cursive (4)
- # data-science (11)
- # datalevin (12)
- # datascript (15)
- # emacs (2)
- # events (1)
- # fulcro (14)
- # graalvm (16)
- # gratitude (23)
- # honeysql (11)
- # jobs (2)
- # jobs-discuss (14)
- # kaocha (1)
- # leiningen (8)
- # nbb (45)
- # off-topic (7)
- # portal (8)
- # re-frame (9)
- # releases (2)
- # shadow-cljs (24)
- # squint (5)
- # tools-build (17)
- # tools-deps (7)
- # vim (5)
I'm getting close to merging the https://github.com/djblue/portal/pull/135 and cutting a release but was wondering if some folks wanted to try it out for usability and regressions 🙏
I’ve tried it out a little and it’s pretty cool. I like the way you integrated the UI without taking up too much space!
The only thing that’s “broken” for me is the output of def
s and defn
s like
(def forty-two
(+
40
1
1))
These produce an exception inside the view:
{:data {:type :reader-exception, :ex-kind :eof},
:runtime :portal,
:cause "EOF while reading.",
:via [{:type , :message "EOF while reading."}],
:stack
"Error: EOF while reading.\n at new cljs.core.ExceptionInfo (+.)\n at Function.cljs.core.ex_info.cljs$core$IFn$_invoke$arity$3 (+.)\n at Function.cljs.core.ex_info.cljs$core$IFn$_invoke$arity$2 (+.)\n at Function.cljs.tools.reader.impl.errors.throw_ex.cljs$core$IFn$_invoke$arity$variadic (+.)\n at Function.cljs.tools.reader.impl.errors.eof_error.cljs$core$IFn$_invoke$arity$variadic (+.)\n at Object.cljs.tools.reader.impl.errors.throw_eof_error (+.)\n at Function.cljs.tools.reader.edn.read.cljs$core$IFn$_invoke$arity$4 (+.)\n at cljs.tools.reader.edn.read_tagged (+.)\n at cljs.tools.reader.edn.read_dispatch (+.)\n at Function.cljs.tools.reader.edn.read.cljs$core$IFn$_invoke$arity$4 (+.)"}
Oh and I think having a view selector along with the other UI buttons would be great 🙂
I think just displaying the var as text would be fine for a first version. We can have a look at “more” once we figure out a way to connect that window into the runtime
without portal we only display #'notebook/forty-two
, so portal just not exploding is already just as good 🙂
Oh and if just displaying a hardcoded content or an empty window it’s probably also fine. I don’t think anyone expects anything fancy with the normal def stuff 😉