Fork me on GitHub
#portal
<
2022-08-30
>
djblue07:08:42

I'm getting close to merging the https://github.com/djblue/portal/pull/135 and cutting a release but was wondering if some folks wanted to try it out for usability and regressions 🙏

👀 3
🆒 1
😮 1
Lukas Domagala22:08:31

I’ve tried it out a little and it’s pretty cool. I like the way you integrated the UI without taking up too much space! The only thing that’s “broken” for me is the output of defs and defns like

(def forty-two
  (+
   40
   1
   1))
These produce an exception inside the view:
{:data {:type :reader-exception, :ex-kind :eof},
 :runtime :portal,
 :cause "EOF while reading.",
 :via [{:type , :message "EOF while reading."}],
 :stack
 "Error: EOF while reading.\n    at new cljs.core.ExceptionInfo (+.)\n    at Function.cljs.core.ex_info.cljs$core$IFn$_invoke$arity$3 (+.)\n    at Function.cljs.core.ex_info.cljs$core$IFn$_invoke$arity$2 (+.)\n    at Function.cljs.tools.reader.impl.errors.throw_ex.cljs$core$IFn$_invoke$arity$variadic (+.)\n    at Function.cljs.tools.reader.impl.errors.eof_error.cljs$core$IFn$_invoke$arity$variadic (+.)\n    at Object.cljs.tools.reader.impl.errors.throw_eof_error (+.)\n    at Function.cljs.tools.reader.edn.read.cljs$core$IFn$_invoke$arity$4 (+.)\n    at cljs.tools.reader.edn.read_tagged (+.)\n    at cljs.tools.reader.edn.read_dispatch (+.)\n    at Function.cljs.tools.reader.edn.read.cljs$core$IFn$_invoke$arity$4 (+.)"}

Lukas Domagala22:08:04

Oh and I think having a view selector along with the other UI buttons would be great 🙂

djblue22:08:15

Yeah, since vars aren't readable, might need to hack in a solution.

djblue22:08:26

I'll see about adding a dropdown for the viewers :thumbsup:

Lukas Domagala22:08:35

I think just displaying the var as text would be fine for a first version. We can have a look at “more” once we figure out a way to connect that window into the runtime

Lukas Domagala22:08:24

without portal we only display #'notebook/forty-two , so portal just not exploding is already just as good 🙂

Lukas Domagala23:08:04

Oh and if just displaying a hardcoded content or an empty window it’s probably also fine. I don’t think anyone expects anything fancy with the normal def stuff 😉