fixed the clear function too

Wait. Are you controlling portal - outside of Emacs - with a hydra - inside Emacs? I have to try this.

yes, that's the purpose of all this line of thinking. It started because I couldn't control the shortcuts, but then I understood the brilliant design decision of accepting UI commands from an external source

💯❤️

Very nice! Thanks! I had super simple setup an advice function to tap the things I evaluated. This is much better! Do you have to click on any element before using the hydra for it to start working? Mine isn't working until I click an element inside portal, then r,h,j,l,k start working.

@UJCC6CE9E No I don't need to click anything, basically the function select-root is used to select the top level element in case nothing is selected (and then I can use h,j,l,k)

@UA7E6DU04 Yes, thanks! Yesterday I got it working, I think that maybe I had an older version of portal because I didn't see the select-root function in the command palette. Btw, have you tried calling copy | copy-path | copy-json from emacs?

Oh yes, that's it, select root was added very recently! Unfortunately I never had a compelling use case that forced me to set up copy | copy-path | copy-json for now, how are you using them?

I sometimes use copy with data that comes from a db/http request or even from taps that I've added. I havent had use cases for the other 2. Calling

(portal/invoke-portal-command
   "(portal.ui.commands/copy portal.ui.state/state)")

Might be a clipboard permission issue or because copy is returning a #object[HTMLTextAreaElement [object HTMLTextAreaElement]] :thinking_face:. Try wrapping it in a (do ... nil) and see if that works.

no 😞

@djblue what should be wrapped in a (do ... nil) ?

(portal.web/eval-str
   "(do (portal.ui.commands/copy portal.ui.state/state) nil)")

Does the browser console complain about permissions?

The code above works for me in chrome :thinking_face:

I can get:

(portal.web/eval-str
   "(.-value (portal.ui.commands/copy portal.ui.state/state))")

I don't see any error related to clipboard permissions

Quick question, do you have a value selected in the UI?

yes, I do when I try the command

Dang, not sure what's up then. Works perfectly for me.

ok, now I explicitly granted clipboard permissions to localhost:3000 and that didn't seems to change anything

@UJCC6CE9E is this working for you?

@djblue are you using the dev version?

I tried both just in case and they both worked 👌

are you on linux? (I'm on linux using chromium)

No, it didn't work for me.

ohh, that might be it. I'm on OSX

I'm also on linux.

Does copy work from the command palette?

Yes

yes

Weird, it's the same https://github.com/djblue/portal/blob/master/src/portal/ui/commands.cljs#L624-L646

doesn't that lack something like:

navigator.clipboard.writeText(copyText.value);

This doesn't copy anything for me:

(let [el (js/document.createElement "textarea")]
    (set! (.-value el) "Hey there")
    (js/document.body.appendChild el)
    (.select el)
    )

(js/document.execCommand "copy") is the key I think

oh I had to expand the preview, sorry

still, it doesn't copy anything in the clipboard

No worries, this method of copying might be outdated and we could switch to a modern approach

Mind switching to navigator.clipboard.writeText(copyText.value); and see if that works in linux?

I'm trying at the repl:

(let [el (js/document.createElement "textarea")]
    (set! (.-value el) "Buongiorno signore")
    (js/document.body.appendChild el)
    (.select el)
    (.-value el)
    (js/Promise.resolve (.writeText (.-clipboard js/navigator) "HEEEEY")))

trying to get the right invocation for the navigator part

the problem with the clipboard API anyway is that:

Don't try the above code in the console. To use the Clipboard API, the document needs to be in a focused state. Otherwise, a DOMException will be thrown.

thinking generally though, this just means that maybe I shouldn't try to call that command from emacs. Instead I could just select the bit I'm interested in, and arrange emacs to insert @p in the buffer

or arrange emacs to put it in the clipboard 😂

Does (js/document.execCommand "copy" false) make any difference?

Or with true as well :thinking_face:

no, no difference with both

ok, thanks for trying 🙏

I think it has to do with how portal is capturing runtime objects. Portal is only checking value equality, not metadata. Since the UI has already received this value, the UI receives the ID of the previous value with the old metadata.

hmm I see. Do we have a way of setting new predicates from the user side? Like, if you have data of this form [[{:a :b}]] I feel having to traverse two layers of vector is rarely the first choice I'd make

I think https://github.com/djblue/portal/commit/42c1ce934d38b9c2e171659e4b7b54467eae02da should fix the metadata issue

I've been thinking about adding a user defined way to specify a function which can pick a default viewer

Is that kinda what you are thinking? If so, what expectations would you have?

yes, that's the kind of think I have in mind. The expectation I would have is being able to easily "patch" the default behavior; so, if none of viewers apply, I fall back to the viewers as they are now

also, I'd like to know how to write more complex visualizers; for example, I'd love to write a visualizer for music or for the custom objects in my code

For custom viewers, there are a few options: • hiccup + existing viewers - only allows composition of existing viewers, no new behavior • vega / vega-lite - pretty extensive data dsl for viz • full reagent component registered via portal.ui.api/register-viewer! and code loading is handled via eval-str , however no direct support for npm libs