This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2022-01-08
Channels
- # announcements (10)
- # beginners (53)
- # calva (22)
- # clj-kondo (21)
- # cljs-dev (1)
- # clojure (18)
- # clojure-europe (2)
- # clojure-filipino (1)
- # clojure-indonesia (1)
- # clojure-my (1)
- # clojure-seattle (6)
- # clojure-sg (1)
- # clojurescript (60)
- # code-reviews (3)
- # conjure (1)
- # cursive (1)
- # datomic (2)
- # figwheel-main (1)
- # fulcro (2)
- # gratitude (1)
- # honeysql (35)
- # lsp (6)
- # malli (5)
- # meander (11)
- # off-topic (27)
- # other-languages (3)
- # play-clj (1)
- # portal (31)
- # sql (13)
- # xtdb (5)
Hey!
I am a fan of portal and have been using it quite a bit when I was on Linux.
But I switched recently to MacOS and noticed that p/open
is broken.
When trying to open as a tab, nothing seems to happen. When open in a new window (default), a new chrome window opens with a blank page.
The CLI works however (a chrome window opens with the proper UI).
Any idea? 🙏
Hi there @UCFG3SDFV, are there any errors in the browser console?
I think sometimes bumping a version can cause issues with how some of the resources are loaded
No error, it's literally a blank window with a blank console.
I didn't bump the version nor change the code, simply executing it from osx.
I blew up .shadow-cljs
as well as .cpcache
just in case, didn't change anything 😞
Initially 0.18.1, same with 0.19.2
osx 12.1 (M1 Max)
The CLI uses open LINK
right?
Any reason p/open
has to use Chrome?
Nope, it opens Chrome whereas my default browser is Brave.
And indeed, when I was reading the code, albeit quickly I confess, it was about (find-chome-bin)
or something like that :thinking_face:
And the CLI works because it relies on calling open LINK
in the shell which does just that, open the default browser
At least that was my quick conclusion
It seems to reach this path https://github.com/djblue/portal/blob/master/src/portal/runtime/browser.cljc#L97
True, but if you pass in the option, the if will kick you to https://github.com/djblue/portal/blob/master/src/portal/runtime/browser.cljc#L89.
Right, on Linux passing false resulted in a tab being opened in my current (and default browser), true But now on osx nothing happens 😕 It must be something silly
What node version are you using?
Yes, that was my hunch too but it's still "darwin"
`
Oh wait
An earlier node version works
But v17.3.0 doesn't
I knew it was something silly! But I've been installing stuff whole day, i didn't consider node could misbehave on something like that Thanks for your help 👌
Ohh, I see the issue. The url being generated is http://::1:49587?fa260c66-f2c4-453c-8df5-9eea6db5262c
. Not sure why the node http server is returning ::1
instead of 127.0.0.1
Ah yes, makes sense 🙂
https://github.com/djblue/portal/commit/5cdba58aa246ac8cae434d772f870a7678df09fc will fix the issue in the next release
And thanks for the fix!
(running on node)