Fork me on GitHub
#portal
<
2021-10-13
>
djblue02:10:59

A few small bug fixes from the last release https://github.com/djblue/portal/releases/tag/0.16.1 🎉

1
👍 2
🎉 4
pez15:10:06

Should a vscode extension user use the same version of the extension as of portal itself?

djblue16:10:04

Currently that isn't a requirement as both versions are compatible with each other.

djblue16:10:07

I don't plan on breaking backwards comparability, but if a new feature is added, you might need to bump both to use it 👌

pez16:10:28

I’m thinking if I can use the current version of the extension as default value for the dependency injection at jack-in. But maybe you do not release a new version of the extension automatically when portal updates?

djblue16:10:50

I plan to always release them in parallel, even if it would have no change to the extension.

djblue16:10:55

That way people can always fallback to using parallel versions to ensure compatibility if I accidentally break something

pez16:10:38

Awesome. I’ll utilize that in Calva’s support then.

👍 1
pez16:10:18

Speaking about that. You had use for getting access to Calva’s REPL connection, right? Are you planning to inject portal into the running REPL? I think we will need to do some changes in our client if so. Changes that I plan to do anyway, because loading stuff into the running app is generally useful and cool. But it can help with triaging if someone else has use for it.

pez16:10:32

Also, I think it would be a pretty awesome Ux if you would use the portal extension to hook itself into the REPL and the Calva user would just tap, tap, tap things.

👍 1
pez16:10:08

My current PR is going from the other direction. Making sure portal is there when the repl starts, and make it easy to start portal and to add the tap.

djblue17:10:25

Yeah, it would be very nice to have access to a users repl connection. The current implementation depends on having a shared filesystem, which means remote repls won't work as easily. Also, injecting the portal runtime would be super nice. And the portal extension could provide useful vs-code commands!

djblue17:10:42

Are there any security concerns with exposing the repl connection to other vs-code extensions?

pez21:10:53

A malicious extension could maybe abuse it, but I don’t know…

djblue21:10:24

Yeah, that's what I'm worried about 😬

djblue21:10:30

I wonder if the risk should be opt-in for the user

seancorfield23:10:12

(I could inline those into the "Portal start" command easily enough)

djblue00:10:08

I really like how a lot of the clover commands result in tapping some data! awesome

seancorfield00:10:48

I've been a big fan of tap> ever since it debuted! Initially, I use Cognitect's REBL with tap>, then switched to Reveal, and now Portal.

💯 1
seancorfield00:10:19

My default "eval" in VS Code/Clover tap>s the result in all cases.