polylith

seancorfield 2025-05-12T18:58:43.328719Z

@tengstrand Polylith master is broken due to this commit https://github.com/polyfy/polylith/commit/6d0f35cf7c86c1687083b79e3776c467fa1e251d See the comment I added to that commit.

tengstrand 2025-05-12T19:33:57.626139Z

Try now. The fix is in both master and cljs-support.

seancorfield 2025-05-12T19:37:30.678689Z

Wow, that was fast!

👍 1
seancorfield 2025-05-12T20:01:01.077479Z

Still broken, it seems: Couldn't read file '/opt/atlassian/pipelines/agent/build/bases/admin/test/ws/admin/model/reporting_test.clj', row: , column: . Message: Unparseable inst value Why can't inst just use Clojure's actual parser here?

seancorfield 2025-05-12T20:01:35.705449Z

Something in this test I suspect:

(defexpect month-date-range-tests
  (let [month-date-range           #'sut/month-date-range
        month-date-range-from-date #'sut/month-date-range-from-date]
    (expect [#inst "2011-12-01" #inst "2012-01-01"]
            (month-date-range-from-date #inst "2011-12-30T23:59:59"))
    (expect [#inst "2011-12-01" #inst "2012-01-01"]
            (month-date-range-from-date #inst "2011-12-01T00"))
    (expect [#inst "2012-01-01" #inst "2012-02-01"]
            (month-date-range-from-date #inst "2012-01-15T07"))
    (expect [#inst "2011-11-01" #inst "2011-12-01"]
            (month-date-range
             (.minusMonths (java.time.OffsetDateTime/of 2011 12 30 23 59 59 0 java.time.ZoneOffset/UTC) 1)))
    (expect [#inst "2011-11-01" #inst "2011-12-01"]
            (month-date-range
             (.minusMonths (java.time.OffsetDateTime/of 2011 12 1 0 0 0 0 java.time.ZoneOffset/UTC) 1)))
    (expect [#inst "2011-12-01" #inst "2012-01-01"]
            (month-date-range
             (.minusMonths (java.time.OffsetDateTime/of 2012 1 15 7 0 0 0 java.time.ZoneOffset/UTC) 1)))))

seancorfield 2025-05-12T20:07:37.641919Z

@tengstrand point_up::skin-tone-2

tengstrand 2025-05-12T20:14:09.926839Z

Sounds like a good idea. Will have a look at that tomorrow.

tengstrand 2025-05-13T04:07:33.305389Z

There is a fix out now. 0.2.22-SNAPSHOT #5 in master. cljs-support is also updated.

seancorfield 2025-05-13T13:28:38.581769Z

Great. I will update Polylith at work and see how it goes.

seancorfield 2025-05-13T14:41:23.510419Z

Looks good so far!

tengstrand 2025-05-13T15:00:29.485669Z

Nice!