Clojurians Log v2

Just to clarify the stable/release regex patterns: although it should need ^ at the start, the * at the end is expanded to .* in a real regex, yes? Or will -* match "zero or more dashes? In which case those tag patterns should be updated to be -.*, i.e., a dash and then "anything"...

that's a good question/spot actually

I just updated our tags at work to this:

:tag-patterns {;; we tag each QA deployment with build-
                :release "^build-[0-9][0-9][0-9][0-9]-"
                :stable  "^stable-"}

(we didn't need the leading ^ really but...)

Yes you are right @seancorfield will change from -* to -.*. Thanks for pointing this out!

So ^stable-.* and ^v[0-9].*.

Not sure about the latter

But perhaps

V then number then anything

I guess we get away with this because we have:

:tag-patterns {;; we tag each QA deployment with build-
                :release "build-[0-9][0-9][0-9][0-9]-*"
                :stable  "stable-*"}

So really we're match "zero or more -" there instead of "anything"?

Yes, I think you get away with it because you don't have tags like "x-stable-1" or similar that you don't want to match, but it will still match tags beginning with "stable-".

Good to know. Thanks!

Just ooc what are some example release version tags you want to support?

^v[0-9].* will match the example in the doc. If people want to match any string starting with v then they can change to ^v[0-9]*.

Fair

Omg me and @jannick.joosten have looked at this for a whole afternoon thank you so much @tengstrand 😛