polylith

seancorfield 2024-06-20T21:52:12.372589Z

There's a regression in the 0.2.20-SNAPSHOT branch -- not sure when since I only just started testing it:

Error 101: Illegal dependency on namespace clojure.extensions in seo.geo.affiliate. Use clojure.interface instead to fix the problem.
  Error 101: Illegal dependency on namespace clojure.extensions in seo.geo.locale. Use clojure.interface instead to fix the problem.
  Error 101: Illegal dependency on namespace web.spec in admin.handlers.membership. Use web.interface instead to fix the problem.
  Error 101: Illegal dependency on namespace web.spec in admin.handlers.promo. Use web.interface instead to fix the problem.
  Error 101: Illegal dependency on namespace web.spec in api.search. Use web.interface instead to fix the problem.
These are due to external libraries that share the same top-ns as our own code (`ws` in our case -- our open source libraries from Clojars). These errors do not appear in 0.2.19.

tengstrand 2024-06-22T19:47:47.769009Z

Hopefully the 101 validation should work now, in 0.2.20-SNAPSHOT #23. I have also fixed the problem that the with:test-snippet config wasn't merged into per project :test config. @seancorfield

seancorfield 2024-06-22T20:29:16.487749Z

Will check it out when I'm back at work. Thanks.

👍 1
seancorfield 2024-06-24T16:17:02.301489Z

Yup, this seems to have fixed the problem. Thank you!

tengstrand 2024-06-24T16:40:20.996559Z

Sounds good!

tengstrand 2024-06-24T20:36:49.469909Z

The :test key per project should also work correctly together with the :with syntax.

seancorfield 2024-06-20T22:14:46.083999Z

There are no bricks called clojure or web so these nses should not be considered part of the workspace (and they were not considered in 0.2.19). ws.clojure.extensions and ws.web.spec are both library nses. This is a complete blocker for us testing 0.2.20 snapshots @tengstrand FYI

tengstrand 2024-06-21T04:48:18.358709Z

Could you export your workspace, while using the latest snapshot version, and send it to me @seancorfield?

seancorfield 2024-06-21T04:48:46.386429Z

Remind me of the preferred command...?

tengstrand 2024-06-21T04:49:10.730089Z

ws out:sean.edn

seancorfield 2024-06-21T04:50:19.786799Z

Okay, wasn't sure if you wanted any options etc on that...

tengstrand 2024-06-21T04:51:58.474979Z

So you get those 101 errors when you run a plain check command?

seancorfield 2024-06-21T04:52:09.762729Z

Yes.

tengstrand 2024-06-21T04:52:15.291139Z

Ok

seancorfield 2024-06-21T04:53:15.460499Z

That is a big file...

tengstrand 2024-06-21T04:54:02.834389Z

You can DM me.

seancorfield 2024-06-20T22:28:58.460679Z

Meanwhile, there's an update to the External Test Runner (v0.5.0) for Polylith that now supports running tests in src directories and the var/include/exclude focus options from Cognitect's test runner (i.e., either a specific list of test vars to run, or whether to include or exclude tests based on metadata such as :integration or :slow or whatever you want): https://github.com/seancorfield/polylith-external-test-runner?tab=readme-ov-file#test-configuration You can use this with Polylith 0.2.19 and earlier by passing the test configuration as an env var, or via the new-in-0.2.20 :test-configs feature.

🎉 3