Fork me on GitHub
#polylith
<
2021-12-02
>
yenda09:12:03

Is the interface the best place to put clojure.spec def and defns?

furkan3ayraktar10:12:59

Yeah, I prefer it this way so it’s very clear when used somewhere else,. I prefer to have a spec implementation namespace, usually, top-ns.component.spec and a sub interface top-ns.component.interface.spec, just like in the realworld example.

seancorfield17:12:54

Yeah, I would favor <top-ns>.<component>.interface.specs (it's more common for Spec nses to be named specs than spec based on what I've seen out in the wild). But only for the Specs themselves -- and perhaps some very small, self-contained predicates that they alone depend on -- any associated or supporting code should be outside any interface.

Lukas Domagala11:12:40

quick question: can I use git submodules as components with polylith?

tengstrand12:12:14

I don’t have much experience with submodules (I talked with Furkan also). Maybe someone else has.

pavlosmelissinos22:12:29

> can I use git submodules as components with polylith It's possible, as long as each submodule points to a repo that only contains a single polylith component. Why would you want to do that though? It kind of goes against the point of polylith. a submodule is basically a soft link (pointer) to the commit sha of another repo. It even has its own remotes. Polylith offers a way to manage multiple projects in the same repo. I don't see how those two goals can be reconciled.

pavlosmelissinos22:12:59

I suppose it would be neat to be able to get components from other polylith repos by pointing each submodule to a path in the target repo but git doesn't support that afaik (yet). edit: of course you can do all that with CLI tools.

Lukas Domagala23:12:57

the reasoning would be to make it easier to integrate projects that aren’t under full control of the polylith workflow into it. for my usecase I’d like to have a polylith project with my own stuff, but put in a lib I’m only contributing to as a component.

pavlosmelissinos00:12:01

I see... If I'm not mistaken, in order for that to work and assuming that you're interested in using the poly tool, the library you're integrating should still adhere to the "rules" of the polylith workspace (e.g. there has to be an "interface" namespace, or whatever you've defined it as in your workspace.edn, the top namespaces should match, etc). So yeah, as long as the library is disciplined enough to do the above, I think you'll be fine.

🙌 1