Fork me on GitHub
#polylith
<
2021-05-14
>
tengstrand03:05:31

Sure, I will speed up the merge into issue-66and do it during the day.

3
tengstrand06:05:20

I have now pushed the last month’s work to the issue-66 branch (da3bccf3a13ac30be8e31fedeab4de53c1efd951) @jshaffer2112 (se comment for details).

🎉 11
tengstrand06:05:02

• rewrote the dependency calculation, to support test dependencies, used by the ‘test’, ‘info’, and ‘deps’ commands. • new column ‘dev’ in the projects section when running the info command. • use depstar for the examples and also by the polylith project itself. • new column ‘type’ in the libs command. • support for passing in e.g. since:SHA, since:head, or since:head~1. • circular dependencies are also calculated for the test context in validation 104. • changes to the ws structure: • merged :src-paths and :test-paths into :paths. • merged :base-names and :test-base-names into :base-names • merged :component-names and test-component-names into :component-names • merged :namespaces-src and :namespaces-test merged into :namespaces • merged :lines-of-code-src and :lines-of-code-test into :lines-of-code • merged :lib-imports-src and :lib-imports-test into :lib-imports • moved in :lines-of-code-total into :lines-of-code as the key :total • also calculate test dependencies for :lib-deps. • also calculate test dependencies for :interface-deps. • added support for indirect test changes to :project-to-indirect-changes. • added test dependencies to :deps, changed from :direct-ifc to :missing-ifc + two new keys :direct and :indirect. • renamed :total-lines-of-code to :lines-of-code-total • new attribute :on-disk for :paths that contains existing paths on disk. • indirect test dependencies are also included when calculating :bricks-to-test-for-project. • if :all is passed in to the deps command, e.g. ‘poly deps project:PROJECT :all’, then all bricks are included in the columns. • validation 107 also includes missing components in the test context. • test depenedencies are also shown in the deps command as a “t”, and suffixed with ” (t)” if a brick is given. • indirect test dependencies are shown as ‘-’ in the ‘deps’ command when a project is given. • possible to execute “poly ws get:settings:vcs:latest-sha branch:master” to show the latest git sha. • :thousand-separator in ~/.polylith/config.edn changed to use “.” because the centered dot was shown as ? in some setups. • some improvements of the documentation, based on input from @seancorfield (more to come) • merged PR #74 + #87 + #86 from master. • improved test coverage of the polylith codebase itself.

seancorfield06:05:59

Wow! Sounds great! I’ll update our SHA at work and let you know what happens!

seancorfield06:05:23

stable since: e381c13 | stable-sean

  projects: 2   interfaces: 3
  bases:    1   components: 3

  project            alias  status   dev
  --------------------------------   ---
  google-search-job  gs      ---     ---
  development        dev     ---     ---

  interface              brick                   gs    dev
  --------------------------------------------   ---   ---
  google-search-console  google-search-console   xx-   xx-
  seo-keyword            seo-keyword             xx-   xx-
  site                   site                    xx-   xx-
  -                      google-search-cli       xx-   xx-
At least nothing basic is broken 🙂

seancorfield06:05:30

It still doesn’t pick up the changes though — do I need to change something in workspace.edn?

seancorfield06:05:48

(this is about the git root being above the workspace root)

tengstrand06:05:09

I haven’t implemented that yet, but I will start working on it now.

seancorfield06:05:33

Yup, saw your comment in the other thread. I added a few comments to the commit.

seancorfield06:05:14

It’ll take me a while to assimilate all of these changes so I may have other comments later 🙂

👍 3
seancorfield06:05:48

And thank you for switching to depstar 🙂 Happy to support anything Polylith needs in that area.

tengstrand07:05:15

Sounds great! Everything went cleaner with depstar. Less code, less complexity = things that I like!

seancorfield06:05:03

Hey, I was reading that! 🙂

😃 3
tengstrand06:05:07

I felt it was time to push it, even though it doesn’t include support for having the git root higher up, but I will start to work on that soon + other features.

tengstrand19:05:36

I have added support having workspaces inside the git root @seancorfield for the issue-66 branch. Check out the latest sha: 2de60069edbba960b8ab9e71dc6c2341615a52ec.

seancorfield19:05:15

Thank you. Checking that out…

tengstrand20:05:18

Cool! Check it out and hopefully it will work.

seancorfield21:05:25

It did — see my posts in the main channel.

seancorfield19:05:59

Looks good — I now see * as expected:

(! 985)-> clojure -M:poly info
  stable since: e381c13 | stable-sean

  projects: 2   interfaces: 3
  bases:    1   components: 3

  project              alias  status   dev
  ----------------------------------   ---
  google-search-job *  gs      ---     ---
  development          dev     ---     ---

  interface              brick                     gs    dev
  ----------------------------------------------   ---   ---
  google-search-console  google-search-console *   xxx   xx-
  seo-keyword            seo-keyword *             xxx   xx-
  site                   site *                    xxx   xx-
  -                      google-search-cli *       xxx   xx-

seancorfield19:05:30

And I moved the tag and now the * are gone — as expected:

stable since: 26c2da0 | stable-sean
(same output but without * and without x in the third column under gs!)

👍 3
🎉 2
seancorfield22:05:22

FYI: I updated clj-new to use the latest SHA in generated projects, and that update will be in the next release (there’s nothing very substantial changed since the last release right now).

👍 2
🚀 2