Fork me on GitHub
#polylith
<
2021-03-31
>
tengstrand07:03:59

I also fixed the problem with the aliases that showed up as ?1, ?2… (in the issue-66 branch) + updated the SHA in the poly alias.

seancorfield16:03:11

Thanks. Will take a look after I’ve had a coffee and provide feedback!

tengstrand16:03:43

Sounds good.

seancorfield16:03:03

I’ll be interested in your feedback on the schema suggestion in my comments.

tengstrand17:03:05

I’m busy, will have a look later.

3
tengstrand20:03:20

I have pushed my changes and commented the PR @seancorfield.

tengstrand20:03:46

I need to update the picture also, because I added a component.

seancorfield20:03:16

Hold off on that for now — the final version will still look a bit different but the PR is a very helpful guide and check-list at this point!

seancorfield20:03:04

I think there’s a bug in how the test helper sets up the database and I think the & db-spec argument should be & [db-spec] since it’s a single optional argument, not an optional sequence of arguments.

seancorfield20:03:58

But I have a slightly different approach in mind that will be easier to discuss if I go ahead and do that refactoring and then you can provide feedback on it once you see the code — the sub-interface suggestion I made in the PR.

tengstrand21:03:51

Sure, make the changes you want, and then I can have a look at it, and yes, looks like I introduced a bug!

tengstrand21:03:28

I have pushed my changes by the way, so feel free to start working on it.

3