This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2021-03-31
Channels
- # announcements (3)
- # babashka (75)
- # beginners (16)
- # calva (124)
- # cider (10)
- # clara (2)
- # clj-kondo (1)
- # cljdoc (4)
- # cljs-dev (14)
- # clojure (104)
- # clojure-australia (4)
- # clojure-czech (5)
- # clojure-europe (14)
- # clojure-germany (48)
- # clojure-nl (4)
- # clojure-serbia (4)
- # clojure-uk (34)
- # clojurescript (60)
- # community-development (16)
- # conjure (12)
- # core-async (34)
- # cursive (42)
- # data-science (7)
- # deps-new (9)
- # depstar (1)
- # emacs (11)
- # events (2)
- # fulcro (15)
- # graalvm (1)
- # inf-clojure (1)
- # jobs (3)
- # jobs-discuss (1)
- # joker (7)
- # juxt (8)
- # lsp (20)
- # malli (42)
- # meander (4)
- # off-topic (5)
- # pathom (2)
- # polylith (13)
- # re-frame (39)
- # reagent (9)
- # reitit (31)
- # releases (2)
- # rewrite-clj (23)
- # shadow-cljs (39)
- # spacemacs (11)
- # specter (6)
- # tools-deps (8)
- # xtdb (12)
@seancorfield I made a https://github.com/seancorfield/usermanager-example/pull/6and the new page looks like https://github.com/tengstrand/usermanager-example/tree/refactor-components.
I also fixed the problem with the aliases that showed up as ?1, ?2… (in the issue-66 branch) + updated the SHA in the poly alias.
Thanks. Will take a look after I’ve had a coffee and provide feedback!
Sounds good.
I’ll be interested in your feedback on the schema
suggestion in my comments.
I have pushed my changes and commented the PR @seancorfield.
I need to update the picture also, because I added a component.
Hold off on that for now — the final version will still look a bit different but the PR is a very helpful guide and check-list at this point!
I think there’s a bug in how the test helper sets up the database and I think the & db-spec
argument should be & [db-spec]
since it’s a single optional argument, not an optional sequence of arguments.
But I have a slightly different approach in mind that will be easier to discuss if I go ahead and do that refactoring and then you can provide feedback on it once you see the code — the sub-interface suggestion I made in the PR.
Sure, make the changes you want, and then I can have a look at it, and yes, looks like I introduced a bug!