Fork me on GitHub
#planck
<
2019-04-17
>
arbscht09:04:44

@mfikes I think I'm satisfied with the tty PR thus far, no further commits incoming, unless you have more suggestions. let me know if/when I should squash it into an atomic commit

mfikes11:04:03

@mail462 Cool. There is no need to squash it yourself; I have GitHub set up so that the "merge" button only allows "squash and merge". There are a few comments I had made in the PR that could be addressed at some point.

arbscht06:04:16

could you clarify which comments in the PR could be addressed at some point? I think the three review comments are resolved. did you add some more? or do you mean discussion about identifying underlying fds for open streams etc?