Fork me on GitHub
#planck
<
2016-07-01
>
johanatan00:07:56

I learned a lot about lldb, javascriptcore, etc.

johanatan16:07:31

@mfikes: did you try out sh-async before merging that PR?

mfikes16:07:49

I tried it after merging. Worked for me.

johanatan16:07:31

On Linux I assume?

mfikes16:07:13

No. I tried it on OS X

johanatan17:07:16

@mfikes: do you think that sh-async is enough to warrant another release of planck 2.0?

mfikes17:07:35

Sure… I can put out a beta 3

mfikes17:07:58

Sorry, alpha 3

johanatan17:07:42

btw, make is failing locally for me.

johanatan17:07:03

any idea on that?

mfikes17:07:12

@johanatan: I’d suggest doing a script/clean at the top. My only guess is it needs to build the ClojureScript compiler afresh given that I’ve set it to build a specific commit hash.

johanatan17:07:38

👍:skin-tone-3:

johanatan17:07:54

That worked.

johanatan21:07:09

@mfikes: not sure if you're aware of this or if it is specific to me but:

Jonathans-MacBook-Pro:screencap jonathan$ brew install --HEAD planck 
==> Cloning 
Updating /Users/jonathan/Library/Caches/Homebrew/planck--git
==> Checking out branch master
==> ./script/build-sandbox
Error: No such file or directory - build/Release/planck

mfikes21:07:56

Yeah… for now you’ll unfortunately need to do brew edit planck and then add

depends_on “maven" => :build
(This is because I have Planck currently depending on building its own ClojureScript compiler.)

johanatan21:07:39

i just ended up doing: build/script on a cloned copy of the src and copying the bin over to /usr/local/bin

johanatan21:07:52

@mfikes: i'm not a huge fan of code/information repetition. would you be opposed to merely surfacing the original docstring on sh-internal from both sh and sh-async ?

mfikes21:07:31

No… if there’s a way

johanatan21:07:45

Ok, I think there should be. I'll look into it.

mfikes21:07:08

(Also consider that 1.x still has the non-async version.)

johanatan21:07:39

So, this works:

cljs.user=> (def doc-string "doc string")
#'cljs.user/doc-string
cljs.user=> (def ^{:doc doc-string} a nil)
#'cljs.user/a

johanatan21:07:17

[how do you get planck to print out the docstring for a var tho? (just to verify that it actually did take effect)]

johanatan22:07:04

Oh, dang it.

johanatan22:07:17

cljs.user=> (doc a)
re-find must match against a string.
	cljs.core/re-find (cljs/core.cljs:9076:12)
	planck.repl/undo-reader-conditional-whitespace-docstring (planck/repl.cljs:2373:38)
	planck.repl/doc* (planck/repl.cljs:2736:3)

johanatan22:07:21

Looks like that might be a bug tho

johanatan22:07:32

i.e., ^{:doc "blah"} may not work either

johanatan22:07:09

Nope, this works:

cljs.user=> (def ^{:doc "blah"} c nil)
#'cljs.user/c
cljs.user=> (doc c)
-------------------------
cljs.user/c
  blah
nil