Fork me on GitHub
#perun
<
2017-02-15
>
bhagany04:02:00

I haven't gotten ahold of a windows machine yet, but I was able to identify some problems and fix a few (locally so far). The crux of the problem is that we're too lax about converting from paths to urls and back. Shouldn't be too difficult to fix fully.

munen08:02:10

@bhagany MS offers free VMs for testing. Officially they are for Web Devs to test IE8-IE11, but I’m sure they won’t mind(; https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/

munen08:02:53

(And this finalises the quota for MS related links that I’m going to share anywhere in 2017^^)

Yehonathan Sharvit09:02:31

Someone mentioned me on slack a couple of weeks ago that he wanted to make a klipse integration for perun

Yehonathan Sharvit09:02:42

Do you know if it has been done?

pesterhazy09:02:55

what would the advantage of that be?

pesterhazy09:02:10

I use perun (and am going to use klipse) so I'm interested obv

pesterhazy09:02:39

but you can just add the script to the <head> and it should klipsify all code tags, no?

Yehonathan Sharvit09:02:27

A couple of advantages:

Yehonathan Sharvit09:02:37

1. make the integration smoother (you don’t have to deal with Klipse urls)

Yehonathan Sharvit09:02:34

2. simplify the configuration: for instance for non-clojure snippets, you want to use the minified version of klipse

Yehonathan Sharvit09:02:55

If I could just remember who is the guy that slacked with me about that… :thinking_face:

Yehonathan Sharvit09:02:08

… He mention other advantages

pesterhazy09:02:50

lost in the 10,000 message black hole?

Yehonathan Sharvit09:02:44

Even if it were 1,000,000 it would have been lost

Yehonathan Sharvit09:02:12

But I cannot find a way to restrict my search to the #klipse channel

pesterhazy09:02:02

we should build an algolia based search for clojurians

pesterhazy09:02:07

that'd be awesome!

jjttjj16:02:27

@bhagany I fixed the issues on windows for me with a few changes to perun.core, but am unsure if there's a better way to structure the solution than my current one. Right now I just have the following constants

(def file-separator (System/getProperty "file.separator"))
(def file-separator-regex (re-pattern
                           (java.util.regex.Pattern/quote
                            file-separator)))
and have replaced all hardcoded slashes and regexes that use slashes with these. Any thoughts? Should I just make a PR?

bhagany16:02:33

@jjttjj It seemed more complicated to me in a few places, because for urls, you always want "/" instead of the system file separator. I would like to see your code though.

bhagany16:02:18

Unfortunately, I am a ... bit busy. I just found out the company I work for is going under, so um... I'm not quite sure when I'll be able to get back to this.

Yehonathan Sharvit19:02:30

@pesterhazy Regarding the integration of klipse that I mentioned earlier today - It was not perun but cyrogen. And it has been done http://cryogenweb.org/docs/klipse.html