How is the upgrade process going for people who just bumped dependency versions? No code changes? Anything broken?
It's been a while. But I followed along with all the 0.8.0 pre-releases for cljdoc. I don't think there has been any significant changes required since. Here's my old https://github.com/cljdoc/cljdoc/pull/1012. Memory is a bit foggy, but highlights of code changes for 0.8.0: • pedestal.test was significantly different, and my integration tests required some rework • switched to new connector • adapted to route changes
The new default router was a bump in the road because it dealt differently with paths ending in '/', which was a significant event for a website whose categorical pages end in '/'. I was happy that the new Pedestal can still use the old-default router. I hope it will not be "fixed" to behave like the new one!
No, we leave the old one alone for just this reason. In an ideal world, all changes would be by accretion, but that wasn't always feasible in Pedestal. 🎶 House Built On A Bad Foundation 🎶
reviewplease https://github.com/pedestal/pedestal/pull/965