Clojurians Log v2

Sorry, guys, I was AFK last week and missed this. Thanks for picking it up! Apologies for the lack of docs. I did think about tests for the "jar with spaces" issue but didn't find any candidates in jars already used by Pedestal. Didn't think of @lee's solution 🙂

Normally I would have just rejected the PRs and made suggestions about filling those gaps, but I think they were both important for the 0.8.0 GA release.

So timing is everything, but I'm also very jazzed when Pedestal shows itself to be a community effort.

I did notice this when running tests:

Call stack: ... io.pedestal.service.resources-test/create-responder -> io.pedestal.service.resources-test/create-responder -> io.pedestal.test/create-responder -> io.pedestal.http/create-servlet
Conflicting routes were identified:
:io.pedestal.service.resources/get-resource (GET /res space/*path) conflicts with route:
 - :io.pedestal.service.resources/get-file (GET /res space/*path)
:io.pedestal.service.resources/head-resource (HEAD /res space/*path) conflicts with route:
 - :io.pedestal.service.resources/head-file (HEAD /res space/*path)

Huh. Me neither. Not sure I get it yet though. Why have they become conflicting?

Is there some option to throw on conflicting paths to make such problems more obvious?

It's because the xf function applies to both file and resource paths. I'm fixing it it my PR.

I wonder if @mithrandir03 would be willing/able to fill in the missing pieces?

I've asked, so far no response. I'm trying to squeeze some time in for this. I really want to get to a GA release.

I think the jetty 12 revert alone is probably worth an rc-3. Personally, I've no problem with an rc-4, but I understand the urge to get the GA out the door. If you get no help with tests/docs for those PRs, I can take a swing at it.

I'd love to help but I don't have the time. If that changes I'll see what I can do.

Ok, I can take a swing at docs and tests. But first, must ask @hlship, would that be helpful?

Many hands make light work. How about you take one of the two PRs, I'll take the other.

Ok, I'll take a stab at 958.

@hlship there's some test implementation choices to make re 958, I'll submit a PR as a proposal, and we can work from there.

Ok, I'll tackle 957.

https://github.com/pedestal/pedestal/pull/960

@hlship Ah I see I missed adjusting :paths for :coverage. Want me to fix?

Done: https://github.com/pedestal/pedestal/pull/961