More progress today but it took a lot of debugging to get right. The new io.pedestal.service.websocket namespace will work identically whether you are using Jetty or Http-Kit. There were a lot of challenges to get three fundamentally different lifecycles to align with each other (the lifecycles of the web socket connection itself - when various callbacks get invoked, when the FnEndpoint class gets instantiated, and so forth).
Hi, I was reading pedestal sources when I came across this function https://github.com/pedestal/pedestal/blob/master/interceptor/src/io/pedestal/interceptor.clj#L58 Line 68, in the case the response isn't a core.async channel, the response is computed a second time if I am not mistaken. Shouldn't the code just be (assoc context :response response) ? I can open an issue if needed. Cheers!
Great catch … it of course passed all tests despite being broken.
I’ll fix it in my current PR.
NP I am glad I was randomly looking at it!
It’s a challenge when there’s no-one to review PRs.
Test only go so far, and you get blind to your own code, especially when I’m fitting in Pedestal work around other things I’m up to. So thanks again!
I get it you're welcome, It seems like you have been doing a quite a lot to push pedestal forward! Thanks!