pedestal

souenzzo 2024-05-20T11:13:20.946959Z

while reading the websockets PR, I noticed the spec namespaces, that I liked BUT, they feel wired. While io.pedestal.http uses the :io.pedestal.http/port keyword to specify the port number, the https://github.com/pedestal/pedestal/blob/master/service/src/io/pedestal/http/specs.clj#L47 namespace actually specify :io.pedestal.http.spec/port keyword. Other libraries like https://github.com/seancorfield/next-jdbc/blob/develop/src/next/jdbc/specs.clj in fact use the .spec namespaces to define the keyword, but as it use -un qualified keywords, it is not wrong.

hlship 2024-05-20T14:01:13.880909Z

That sounds like a bug. I must have been sloppy moving the specs out to their own namespace.

hlship 2024-05-20T14:01:34.250899Z

Should have been caught by tests.

hlship 2024-05-24T16:31:39.658699Z

Yep, tests were not instrumenting at the right time to catch these.

hlship 2024-05-24T16:31:49.588359Z

Working on the fix.

hlship 2024-05-24T16:54:57.354339Z

https://github.com/pedestal/pedestal/pull/848