Fork me on GitHub
#pedestal
<
2022-04-10
>
souenzzo03:04:51

@andreolvr0 this line is wrong. I think that you can open a pull request fixing it

d17:04:43

Guess someone already tried that, the last commit on that file is from a https://github.com/pedestal/pedestal/pull/668that removed defroutes and added expand-routes , but just the removal of defroutes landed on master... See the https://github.com/pedestal/pedestal/pull/668#issuecomment-700073719 on the PR, so I'm confused... maybe this is a bug?

souenzzo01:04:31

this commit introduced the bug https://github.com/pedestal/pedestal/commit/50fe5ea89108998ac5a79a02a44432fd111ea6f8 I think that a PR that only change this line can be merged https://github.com/pedestal/pedestal/blob/master/samples/hello-world/src/hello_world/server.clj#L32 The PR #668 proposed to change port and many other unwanted changes.

d17:04:38

But thehttp://pedestal.io/guides/hello-world#_routes uses expand-route :man-shrugging: