Fork me on GitHub
#pedestal
<
2018-12-18
>
mkvlr08:12:15

might I suggest again that it would be good to cut a pedestal release that’s compatible with Clojure 1.10 now that’s been released?

👍 12
8
mkvlr08:12:51

in the meantime people that want to upgrade Clojure can use io.pedestal/pedestal.log {:git/url "" :sha "5ab1c9770472694f94d0835cda412ba753b28809"} if they’re using deps.edn

❤️ 4
souenzzo11:12:33

@mkvlr you can also force a old version of core.specs org.clojure/core.specs.alpha {:mvn/version "0.2.36"}

ddeaguiar13:12:44

Yep, I will work on cutting a release. Sorry about the delay!

🙏 8
👍 4
ddeaguiar19:12:01

@mkvlr, I just cut a Pedestal release (`0.5.5`). I’ll posting release notes later but the TL;DR is that it’s a minor release driven by the io.pedestal.log/Clojure 1.10 incompatibility.

👏 12
👍 4
donaldball21:12:24

I’m using pedestal log and am looking to send e.g. a slack notification whenever an error is logged. I’m trying to decide between overriding the default logger and passing an explicit logger into all of my log calls. There are few different ways I can see to make this work, curious if anyone has done or seen something similar and can speak to their experience.

ddeaguiar21:12:32

@donaldball, had the need to do that but I’d be careful conflating logging with Slack notifications, or third party integrations in general

ddeaguiar21:12:55

But overriding the default logger seems like the cleaner way to do it

donaldball22:12:00

Yeah, rate limiting and message size concerns are duly noted, but it’s a reasonable choice for this app

donaldball22:12:09

The thing that seems most annoying about this route is that I only want to add a behavior, not replace the existing behavior, so I have to copy https://github.com/pedestal/pedestal/blob/master/log/src/io/pedestal/log.clj#L248-L249