Fork me on GitHub
#pedestal
<
2018-10-11
>
martinklepsch14:10:15

What’s the right way to add one interceptor globally without replicating default-interceptors in a codebase?

ddeaguiar15:10:12

call io.pedestal.http/default-interceptors before io.pedestal.http/create-server and manipulate the io.pedestal.http/interceptors collection in between

ddeaguiar15:10:38

The router is the terminal interceptor so add your interceptor(s) before that

mkvlr15:10:52

@ddeaguiar do you have plans to push a release with the fixes for Clojure 1.10 soon? Looks like RC-1 is now out.

mkvlr15:10:05

Having trouble to import pedestal through JitPack…

ddeaguiar15:10:02

Nothing concrete yet. Let me bring that up internally and report back here.

🙏 4
mkvlr15:10:59

@jvtrigueros do you happen to know how I can just import pedestal.log from JitPack?

mkvlr15:10:11

I currently have com.github.pedestal/pedestal {:mvn/version "e6b6286c6b"} in my deps.edn

mkvlr15:10:47

trying to replace io.pedestal/pedestal.log {:mvn/version "0.5.4"} with a version from git

jvtrigueros15:10:54

@mkvlr I've only used JitPack with Leiningen. I don't know if works with clj deps, I've never used it before, does it allow you to add custom repositories?

mkvlr15:10:07

yeah, I have that working

mkvlr15:10:50

but I’m not sure it works for repositories where the file is in a subpath, i.e. https://github.com/pedestal/pedestal/tree/master/log

ddeaguiar15:10:05

@mkvlr if you are using deps.edn why not specify a pedestal git-sha1 directly?

👍 4
ddeaguiar15:10:15

no need to use JitPack

mkvlr15:10:39

@ddeaguiar wouldn’t the have to be a pom.xml or deps.edn in the pedestal repo for that to work?

ddeaguiar15:10:15

ah yeah, right.

ddeaguiar15:10:21

well here’s an alternative

ddeaguiar15:10:36

create a fork and add a deps.edn

mkvlr15:10:50

right! forgot about that

ddeaguiar15:10:18

In the meantime I’ll discuss cutting a release internally

mkvlr15:10:32

great, thank you!

mkvlr15:10:25

io.pedestal/pedestal.log {:git/url "" :sha "5ab1c9770472694f94d0835cda412ba753b28809"} if someone else wants to use it

orestis15:10:46

Committing a deps.edn directly in pedestal doesn’t need a release, right? Would such a PR be accepted?

4
ddeaguiar16:10:07

@U7PBP4UVA possibly but I recommend opening an issue first

jvtrigueros16:10:39

@mkvlr FWIW here's what you would need if you wanted to make it work with JitPack:

{:deps      {com.github.pedestal/pedestal {:mvn/version "e6b6286c6b"}}
 :mvn/repos {"jitpack" {:url ""}}}

mkvlr16:10:22

@jvtrigueros I did have it running so far, but I only want the log app, not everything…

jvtrigueros16:10:47

I've never used JitPack that way, sounds like you've worked it out though!