Fork me on GitHub
#pedestal
<
2017-03-13
>
thegeez11:03:55

@bradford for the route syntax you're using you need

thegeez11:03:59

["/echo"
  ^:interceptors [(b/body-params)] 
  {:post test-channel}]

deg13:03:52

Is it better to ask Vase questions in the #vase channel (which seems to be very quiet) or here?

deg13:03:28

Hmm, LOL, looks like that channel has only two subscribers (including me). So, repeating question here:

deg13:03:41

I'm trying to run the petstore-full sample (https://github.com/cognitect-labs/vase/tree/master/samples/petstore-full) but I'm getting an error Connection Refused localhost:4335

deg13:03:50

I did git clone & lein install & cd samples/petstore-full/ & lein run

deg13:03:32

Hmm, I'm guessing that I need to start Datomic, but how?

jimmy13:03:55

you can quick start that vase example by replacing datomic uri from :datomic-uri "datomic:" to :datomic-uri "datomic:" . So you don't have to setup datomic free.

ddeaguiar13:03:34

Vase creates the db on startup if it doesn’t already exist

ddeaguiar13:03:04

By using an in memory datomic uri, you don’t have to do any additional setup

ddeaguiar13:03:44

To use Datomic Pro and a non in-memory db, you need to startup a separate Datomic process

deg13:03:00

Thanks. I do this in all five of the .edn files?

ddeaguiar13:03:19

In case you’re interested, here’s where the Datomic DB get’s initialized. https://github.com/cognitect-labs/vase/blob/master/src/com/cognitect/vase.clj#L45

deg13:03:28

Thanks, that worked!

deg13:03:58

How could i have started up a separate Datomic process, if I didn't want to edit those files?

ddeaguiar13:03:06

Once you unzip the archive, there’s a bin dir

deg13:03:58

Thanks. And, I assume, some obvious help file inside saying what to run.

ddeaguiar13:03:16

hmm, looking. Been a while since I’ve run Datomic free

ddeaguiar13:03:22

should be the same as pro

deg13:03:31

Am I missing something about the Vase philosophy? The docs say that it is self-contained with Datomic enclosed. Yet, the sample app is configured to need Datomic pre-installed or undocumented changes to its config file.

deg13:03:25

Stranger, the Vase sample app mentions that changes are needed to move from Datomic Free to Pro. But, no mention of what is needed for the in-mem version that comes with Vase itself.

deg13:03:08

(Is this even the right channel for me to be venting about this? Or is there a more Vase-specific place? -- #vase seems to abandoned)

ddeaguiar13:03:31

So let me make sure I’m not giving you bad advice, It’s been a while since I’ve run the vase samples.

ddeaguiar13:03:08

@deg, so for now I think this is the right place for your Q’s.

ddeaguiar13:03:39

re: Datomic free, it requires you to spin up a local transactor using the bin/transactor cli which is available when you download Datomic free

ddeaguiar13:03:59

Vase does include Datomic free as a dependency but that’s for the peer

ddeaguiar14:03:27

The Vase samples shouldn’t really depend on Datomic free. An In-memory DB would be better

ddeaguiar14:03:25

I’d recommend using at least Datomic free when running a real hobbie system. For Prod I’d consider Datomic Pro.

ddeaguiar14:03:50

for exploration, in memory db’s are fine

ddeaguiar14:03:32

@deg There are definitely gaps in the docs that need to be closed.

deg14:03:33

Got it, thanks. I'm putting together a small PR with this and some other minor typos I found in the docs. I was going to just add to the readme, giving the change you supplied above. But, would it be better to instead change the .edn files so they work immediately?

deg14:03:57

(same effort for me; I either commit the .edns I changed or the readme I changed)

ddeaguiar14:03:35

@deg I’d create a separate PR for changing the edn files to use an in memory db plus the readme update.

ddeaguiar14:03:42

that would be super helpful

deg14:03:52

will do.

deg14:03:05

Time allowing, I'll review the other samples too.

ddeaguiar14:03:18

Great, thanks for digging in!

deg14:03:47

Most of the other samples work as is. But, vasebi crashes on first connection to localhost:8080. I don't grok the entire stack trace, but looks like the immediate cause is an NPE.

alanspringfield19:03:07

@ddeaguiar Is there anyway I can help with the development of Vase somehow? It seems very interesting. I'm familiar with Clojure(script) but haven't had any experience contributing to open-source.

ddeaguiar20:03:46

@alanspringfield, there sure is. There are gaps in the documentation. At minimum the creation of issues around that would be useful. There are already some issues for that as well. If you’d like to contribute to the code, be sure to check out the Contributing section of the README (https://github.com/cognitect-labs/vase#contributing).

ddeaguiar20:03:50

I highly recommend creating an issue and soliciting feedback for any remotely significant change… before doing any of the work.

ddeaguiar20:03:30

In any case, doc fixes are a great way to dive into open source contribution.