So I just noticed something in Pathom 2. It seems if you set ::pc/cache? false and ::pc/batch? true, then it causes the batching to be ignored. Is this intentional @wilkerlucio? I don’t really understand why this would be necessary.
this looks like an oversight to me
Actually playing with it, it looks like the planner has a loop, and you can’t break out of it without a redesign, so the caching is required in order to make it work at all?
hello Tony, if I remember correctly that might be limitation of this implementation, you need caching for batching to works, but I'm open to discuss ways to mitigate it
the current impl will rely on the cache to re-use, in that sense, the batching works as an ahead-of-time cacher for the values that will come, one potential alternative is to have some other kind of cache to hold these, but we have to think of what the implications are, the caching makes it globally cached (for any point of the current query), and a batch without cache might mean we only wanna cache for that specific entity path (instead of globally)