Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2021-07-05

Channels

#pathom
<
2021-07-05
>
nivekuil01:07:16

seems I can't upgrade past https://github.com/wilkerlucio/pathom3/commit/4ddc0b765ceeecb0587cc7e031cb834bdc3c0444 or else queries that hit a few of my resolvers error with 

com.wsscode.pathom3.connect.runner.async/run-node!                 async.cljc:  328
java.lang.IllegalArgumentException: No matching clause: :com.wsscode.pathom3.connect.planner/node-unknown
any breaking changes expected? I was on the commit right before that 7e61113f1818e63d9528e61344a79bca20db969c and that's also the last one that works.. weird

wilkerlucio03:07:34

there was a breaking change regarding the ::pcr/wrap-resolve extension, do you have a plugin using that?

wilkerlucio04:07:23

but may be a bug, seems an old change, can you make a repro case?

nivekuil05:07:27

hmm.. there's an and node that references 11 but there is no node-id 11

nivekuil05:07:33

so pcp/get-node returns nil for that node-id

nivekuil05:07:45

oh, 7e6 is actually a different branch from 4ddc entirely.. github makes it look linear 😕

nivekuil05:07:15

terrible hack I know, but I just set pcp/node-kind to default to ::node-resolver instead of ::node-unknown and it works on master

nivekuil05:07:36

I can't figure out a repro, happens even without any plugins

wilkerlucio13:07:58

can you try setting ::pcp/optimize-graph? false on your env and see if you still see the issue?

wilkerlucio13:07:00

and to confirm, you see that on master?

nivekuil20:07:41

optimize-graph? seems to have no effect. still just seems to loop through a few run-and-node! calls before blowing up. yes, all this is done on master

wilkerlucio05:07:50

a repro would be great, so can try to figure what's causing the issue

mitchelkuijpers13:07:40

What is the best way to handle exposing errors with the remove-stats-plugin cominbed with the attribute-errors-plugin? I tried following this: https://pathom3.wsscode.com/docs/built-in-plugins#remove-stats but when I add the remove-stats-plugin before the attribute-errors-plugin I lose all errors and will just return an empty map for a failing resolver. I alsno noted a deprecation message. I already turned off that transit exposes metadata so maybe I shouldn't care

mitchelkuijpers14:07:01

Ah I fixed it by adding: :com.wsscode.pathom3.connect.runner/run-stats-omit? true to the env

mitchelkuijpers14:07:59

Ah then I still have the problem that when a resolver fails the parser returns an empty map

wilkerlucio14:07:46

just taking a look at it now

wilkerlucio14:07:12

not ideal, but one option is to just not encode meta on the transit as a workaround for now

wilkerlucio14:07:55

and I deprecated the remove-stats, and renamed that omit flag

wilkerlucio14:07:02

- `::pcr/run-stats-omit?` => `::pcr/omit-run-stats?`
- `::pcr/run-stats-omit-resolver-io?` => `::pcr/omit-run-stats-resolver-io?
`

wilkerlucio14:07:25

sorry the breakages, during when it still on time, planning to release an alpha this week

aw_yeah 2
mitchelkuijpers21:07:27

No worries at all it is expected, pathom3 is working very solidly already

wilkerlucio14:07:36

hello everyone, for anyone using Pathom 3, there is a new option ::pcr/fail-fast? true that you can use, this way exceptions get thrown up from resolvers/mutations immediatly

🙏 7
👍 8
souenzzo20:07:45

Can we fail fast just mutations?