Fork me on GitHub
#pathom
<
2021-05-05
>
jmayaalv09:05:53

@wilkerlucio Not sure if an error on my side but when we run with guardrails enabled i get the following error

ERROR com/wsscode/pathom3/connect/runner.cljc:520 run-and-node!'s return type
....my huge env here...
should satisfy

  nil?
not pretty sure why, everything works fine if we disable guardrails, could it be something with the spec? this started to happen after the recent changes to the planner. The error starts to appear when running with this commit https://github.com/wilkerlucio/pathom3/commit/2863abe97d4c193d7ed5db31ad389fd5fded3197

wilkerlucio14:05:25

thanks! the spec was wrong, fixed on master

👍 3
nivekuil21:05:42

pathom viz crash when I try to view a request, version 2021.4.22:

Listening to ipc renderer events
shared.js:166 Error: Cannot compare :date to 1
    at $APP.cljs.core.Keyword.cljs$core$IComparable$_compare$arity$2 (shared.js:4619)
    at Object.$APP.cljs.core._compare (shared.js:3103)
    at $APP.cljs.core.compare (shared.js:3344)
    at shared.js:4329
    at Object.$APP.cljs.core.tree_map_add (shared.js:4329)
    at $APP.cljs.core.PersistentTreeMap.cljs$core$IAssociative$_assoc$arity$3 (shared.js:4351)
    at $APP.cljs.core.PersistentTreeMap.cljs$core$ICollection$_conj$arity$2 (shared.js:4354)
    at $APP.cljs.core._conj (shared.js:3007)
    at Function.$APP.cljs.core.iter_reduce.cljs$core$IFn$_invoke$arity$3 (shared.js:3359)
    at Function.$APP.cljs.core.reduce.cljs$core$IFn$_invoke$arity$3 (shared.js:3364)
shared.js:8148 INFO [com.fulcrologic.fulcro.rendering.multiple-roots-renderer:152] - Optimized render failed. Falling back to root render.
shared.js:166 Error: Cannot compare :date to 1
    at $APP.cljs.core.Keyword.cljs$core$IComparable$_compare$arity$2 (shared.js:4619)
    at Object.$APP.cljs.core._compare (shared.js:3103)
    at $APP.cljs.core.compare (shared.js:3344)
    at shared.js:4329
    at Object.$APP.cljs.core.tree_map_add (shared.js:4329)
    at $APP.cljs.core.PersistentTreeMap.cljs$core$IAssociative$_assoc$arity$3 (shared.js:4351)
    at $APP.cljs.core.PersistentTreeMap.cljs$core$ICollection$_conj$arity$2 (shared.js:4354)
    at $APP.cljs.core._conj (shared.js:3007)
    at Function.$APP.cljs.core.iter_reduce.cljs$core$IFn$_invoke$arity$3 (shared.js:3359)
    at Function.$APP.cljs.core.reduce.cljs$core$IFn$_invoke$arity$3 (shared.js:3364)
shared.js:25 Uncaught Error: Cannot compare :date to 1
    at $APP.cljs.core.Keyword.cljs$core$IComparable$_compare$arity$2 (shared.js:4619)
    at Object.$APP.cljs.core._compare (shared.js:3103)
    at $APP.cljs.core.compare (shared.js:3344)
    at shared.js:4329
    at Object.$APP.cljs.core.tree_map_add (shared.js:4329)
    at $APP.cljs.core.PersistentTreeMap.cljs$core$IAssociative$_assoc$arity$3 (shared.js:4351)
    at $APP.cljs.core.PersistentTreeMap.cljs$core$ICollection$_conj$arity$2 (shared.js:4354)
    at $APP.cljs.core._conj (shared.js:3007)
    at Function.$APP.cljs.core.iter_reduce.cljs$core$IFn$_invoke$arity$3 (shared.js:3359)
    at Function.$APP.cljs.core.reduce.cljs$core$IFn$_invoke$arity$3 (shared.js:3364)

nivekuil21:05:03

works on most requests, not sure what's different about that one. the tick tagged literal breaking it? do I need to add a transit handler somewhere

nivekuil22:05:25

return value is [{0 0, :date #time/date "2021-05-05", 7 0, 20 0, 1 0, 4 0, 15 4.433987204485146, 21 0, 13 0, 22 0, 6 0, 17 0, 3 0, 12 0, 2 0, 23 0, 19 0, 11 0, 9 0, 5 0, 14 0, 16 0, 10 0, 18 0, 8 0}]

wilkerlucio23:05:54

ok, I think I know what it is, pathom viz sorts the keys for readability

wilkerlucio23:05:13

so its trying to compare the date key with the numbers, and that explodes

wilkerlucio23:05:37

can you open an issue in pathom viz for that please?

nivekuil00:05:31

done, thanks for looking into it

👍 2