Fork me on GitHub
#pathom
<
2021-03-08
>
markaddleman19:03:21

This query fails due to "insufficient data" for the formatted-metric-query resolver even though the unformatted-metric-query resolver succeeds and requires a subset of inputs and produces the necessary output.

markaddleman19:03:26

This is my first time using Pathom Viz (very nice tool, btw!). From what I can tell of the plan, it looks like unformatted-metric-query and formatted-metric-query end up as siblings when I think they one should be a child of the other.

wilkerlucio19:03:08

seems wrong, will take a closer look later today

👍 3
wilkerlucio15:03:20

were you able to upgrade? I remember you having issues yesterday

markaddleman15:03:37

Thanks for checking in. I'm still having a problem but it's a bit different than yesterday. I'm beginning to suspect something is corrupted in my cursive/intellij setup

wilkerlucio15:03:08

yeah, I can't reproduce the issue, and the CI in other projects is able to download and use the dep fine, so I guess it is something on your setup, but if you find something please let me know

markaddleman16:03:25

So, it's not an intellij problem. I created a new project whose deps.edn is

{:deps {com.wsscode/pathom3 {:git/url ""
                             :sha     "beaf0053e906a18d8bc9d96995e9903995c6926d"}}}
When I run clj -X:deps tree I get
org.clojure/clojure 1.10.1
  . org.clojure/spec.alpha 0.2.176
  . org.clojure/core.specs.alpha 0.2.44
com.wsscode/pathom3  beaf005
  . com.fulcrologic/guardrails 1.1.4
    . expound/expound 0.8.5
  . com.wsscode/cljc-misc 2021.03.09
  . com.wsscode/log  1ac6100
    X com.fulcrologic/guardrails 1.1.3 :older-version
  . org.clojure/core.async 1.3.610
    . org.clojure/tools.analyzer.jvm 1.1.0
      . org.clojure/tools.analyzer 1.0.0
      . org.clojure/core.memoize 1.0.236
        . org.clojure/core.cache 1.0.207
          . org.clojure/data.priority-map 1.0.0
      . org.ow2.asm/asm 5.2
      . org.clojure/tools.reader 1.3.2
  . funcool/promesa 6.0.0
  . edn-query-language/eql 1.0.2
    . org.clojure/spec.alpha 0.2.176
    . org.clojure/core.specs.alpha 0.2.44
  . potemkin/potemkin 0.4.5
    . clj-tuple/clj-tuple 0.2.2
    . riddley/riddley 0.1.12
The only weird thing is the gaurdrails entry. Should my deps reference on gaurdrails directly?

markaddleman16:03:02

ah, on closer inspection, I see that pathom3 depends on guardrails 1.1.4 and com.wsscode/log depends on 1.1.3. I'm guessing this is the issue? I'm going to figure out how to force a version in deps

wilkerlucio16:03:20

it shouldn't be an issue to have then in different versions, it should just pick the latest

wilkerlucio16:03:46

but strange that its listing both on the deps tree

wilkerlucio16:03:55

tried bumping clojure as well?

wilkerlucio16:03:37

I got the same output]

wilkerlucio16:03:42

but I think its only saying that this is not used

wilkerlucio16:03:49

when I just do clj it opens the REPL fine

wilkerlucio16:03:56

is that different for you?

markaddleman16:03:30

Opening a repl is fine but requiring a pathom ns causes a problem:

➜  test-pathom3 clj
Clojure 1.10.1
user=> (require 'com.wsscode.pathom3.connect.built-in.resolvers)
Execution error (FileNotFoundException) at user/eval146 (REPL:1).
Could not locate com/wsscode/pathom3/connect/built_in/resolvers__init.class, com/wsscode/pathom3/connect/built_in/resolvers.clj or com/wsscode/pathom3/connect/built_in/resolvers.cljc on classpath. Please check that namespaces with dashes use underscores in the Clojure file name.
user=> 

markaddleman16:03:57

More info: I forked pathom3 and downgraded com.wsscode/cljc-misc to 2021.02.27 (based on nothing but a hunch). I can require a pathom3 namespace successfully. I'll look at cljc-misc and see if something obvious pops out

wilkerlucio18:03:46

strange, I still can't reproduce your issue

wilkerlucio18:03:57

this is in a blank folder that only has a deps.edn with pathom3 latest

markaddleman19:03:47

I wonder if clojars has a corrupted cljc-misc jar? Are you building that locally?

markaddleman19:03:16

To refute my own theory: I exploded both versions of cljc-misc locally and they look ok

wilkerlucio20:03:42

I got a repro and fix, check this out:

wilkerlucio20:03:46

wilkerlucio@Wilkers-MacBook-Pro-2 pathom-simple % rm -rf ~/.m2/repository/com/fulcrologic/guardrails
wilkerlucio@Wilkers-MacBook-Pro-2 pathom-simple % rm -rf ~/.m2/repository/com/wsscode/cljc-misc
wilkerlucio@Wilkers-MacBook-Pro-2 pathom-simple % clj
Clojure 1.10.1
(require 'com.wsscode.pathom3.connect.built-in.resolvers)
Syntax error (FileNotFoundException) compiling at (com/wsscode/pathom3/connect/built_in/resolvers.cljc:1:1).
Could not locate com/fulcrologic/guardrails/core__init.class, com/fulcrologic/guardrails/core.clj or com/fulcrologic/guardrails/core.cljc on classpath.
^Der=>
wilkerlucio@Wilkers-MacBook-Pro-2 pathom-simple % clj
Clojure 1.10.1
^Der=>
wilkerlucio@Wilkers-MacBook-Pro-2 pathom-simple % clj -Stree
Downloading: com/wsscode/cljc-misc/2021.03.09/cljc-misc-2021.03.09.pom from clojars
Downloading: com/fulcrologic/guardrails/1.1.4/guardrails-1.1.4.pom from clojars
Downloading: com/wsscode/cljc-misc/2021.03.09/cljc-misc-2021.03.09.jar from clojars
Downloading: com/fulcrologic/guardrails/1.1.4/guardrails-1.1.4.jar from clojars
...

wilkerlucio20:03:01

after that, it downloaded things and worked again

wilkerlucio20:03:58

(first delete guardrails and cljc-misc, all versions, then started CLJ, at that point I was abro to repro your issue)

wilkerlucio20:03:18

I expected it to download again on a simple clj, it didn't, but it did when I ran clj -Stree

wilkerlucio20:03:50

after that I got back working as normal

markaddleman22:03:59

Thanks for digging into this! I'm slammed with another task right now but I'll take a look at this tomorrow

markaddleman18:03:20

I'm just getting back to this. As it turns out, my issue was resolved by rm -rf ~/.gitlibs . Something must have been corrupted in there

wilkerlucio18:03:28

glad to hear its all back 🙂

👍 3
markaddleman19:03:47

When I try to include the latest pathom3 sha, clj reports the following error:

Error building classpath. Manifest type not detected when finding deps for com.wsscode/pathom3 in coordinate {:git/url "", :sha "96fc43469b4f1049dbbdc375d698e1c64e44de01"}

wilkerlucio19:03:49

strange, just tested on a new project and worked fine, can you try cleaning the .cpcache and trying again?

markaddleman19:03:07

I get the same error 😕

markaddleman19:03:16

I tried on a fresh computer and got the same results