Fork me on GitHub
#pathom
<
2020-08-04
>
Tyler Nisonoff18:08:53

Hey all - beginner question I'm going through the book, and cannot get the parameters section to work I found https://github.com/wilkerlucio/pathom/blob/3242250e03f5f6b4c5faae1162e6358e9c9a36c1/docs-src/modules/ROOT/examples/com/wsscode/pathom/book/connect/parameters.cljs But I always get:

Execution error (ExceptionInfo) at com.wsscode.pathom.parser/expr->ast (parser.cljc:104).
Invalid expression 
Running the parser as specified in the comment block I'm using pathom version 2.2.31, clojure 1.10, etc. -- am I missing something obvious?

souenzzo18:08:44

@tylernisonoff Where is (<!! (parser {} [(::instruments {:sort :instrument/brand})])) Should be (<!! (parser {} '[(::instruments {:sort :instrument/brand})]))

3
souenzzo18:08:38

When you do [(:ident {:param 42})] on Clojure/REPL it actually evaluates to [nil], which is a invalid EQL On Clojure/REPL, when you need "a EDN list", like (1 2 3) you need to quote it.

Tyler Nisonoff18:08:02

ahhh got it, duh 🙂 Thank you! Think it's worth me submitting a PR to update this file in the examples?

souenzzo18:08:00

PR are welcome 🙂 cc @U066U8JQJ

Tyler Nisonoff18:08:13

cool will do!

👍 3
Tyler Nisonoff20:08:36

https://github.com/wilkerlucio/pathom/pull/169 I included a note in the docs about this in the PR, but can remove that if it's unwarranted. (or happy to re-word it)

souenzzo12:08:17

added a small comment

Tyler Nisonoff12:08:02

:face_palm: thanks for catching -- updated

Tyler Nisonoff12:08:44

The "re-request review" button doesn't seem to do anything for me.. :thinking_face: :man-shrugging:

Tyler Nisonoff00:08:43

@U2J4FRT2T when you can, mind reviewing the PR again?

souenzzo00:08:12

Just @U066U8JQJ can merge

👍 3