This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2020-07-14
Channels
- # announcements (10)
- # babashka (14)
- # beginners (51)
- # calva (2)
- # cider (29)
- # cljs-dev (1)
- # cljsrn (3)
- # clojure (185)
- # clojure-dev (15)
- # clojure-europe (6)
- # clojure-italy (2)
- # clojure-nl (6)
- # clojure-uk (45)
- # clojurescript (4)
- # conjure (12)
- # datomic (37)
- # duct (37)
- # figwheel-main (15)
- # helix (23)
- # interceptors (1)
- # jobs (1)
- # jobs-discuss (11)
- # jvm (5)
- # luminus (3)
- # malli (15)
- # off-topic (69)
- # pathom (8)
- # pedestal (2)
- # re-frame (7)
- # reagent (58)
- # reitit (33)
- # remote-jobs (1)
- # rum (14)
- # sci (7)
- # shadow-cljs (15)
- # spacemacs (9)
- # testing (19)
- # timbre (3)
- # tools-deps (14)
Comment any node of this query, and it will work but these nodes causes a exception
(let [parser (ps/connect-serial-parser
{::ps/connect-reader pc/reader3}
[(pc/constantly-resolver :f "f")
(pc/constantly-resolver :e "e")])]
(parser {}
'[{:>/a [(:e {:p :p1})]}
{:>/b [(:e {:p :p2})]}
{:>/c [:f]}
{:>/d [:f]}]))
@U066U8JQJ should I open a issue?
(p/lift-placeholders-ast {}
{:type :root
:children [{:type :join
:dispatch-key :>/a
:key :>/a
:children [{:type :prop :dispatch-key :e :key :e}]}
{:type :join
:dispatch-key :>/b
:key :>/b
:children [{:type :prop :dispatch-key :e :key :e :params {}}]}
{:type :join
:dispatch-key :>/c
:key :>/c
:children [{:type :prop :dispatch-key :f :key :f}]}
{:type :join
:dispatch-key :>/d
:key :>/d
:children [{:type :prop :dispatch-key :f :key :f}]}]})
yes, open the issue please 🙏
I end up seen that the issue is:
When you try to merge to nodes with different params, the merge returns nil
lift-placeholders ignores the "nil" and continue working and create wired results
i think that maybe merge-queries
should throw something like can't merge nodes a and b
But sure, it's a breaking change, so pc/reader4
nah, reader3 is mostly an experiment, and tbh I think the merge-queries shouldnt be like that, Im considering making the planner aware of placeholders so he can deal with it directly, this may be a better way to avoid those