Fork me on GitHub
#pathom
<
2019-12-02
>
wilkerlucio20:12:13

its supposed to, but to be fair I don't even remember last time I tried it, so may be buggy, if you find some issue with it please let me know

Björn Ebbinghaus20:12:34

Do I have to do anything special? It seems like the recursion depth int is "leaking" into my resolvers. class java.lang.IllegalArgumentException: Don't know how to create ISeq from: java.lang.Long

Björn Ebbinghaus20:12:47

Actually forget the "leaking". The exception has to come from pathom. not my resolver.

wilkerlucio20:12:56

can you get me a small reproduction example of the issue?

wilkerlucio20:12:14

no, it should work the same as ...

wilkerlucio20:12:35

(but with the bound limit, of couse :))

Björn Ebbinghaus20:12:49

I investigated.. When I disable the error-handler-plugin I see that the Exception is thrown by transit on the way out..

Björn Ebbinghaus20:12:49

[{:type java.lang.IllegalArgumentException
   :message "Don't know how to create ISeq from: java.lang.Long"
   :at [clojure.lang.RT seqFrom "RT.java" 557]}]
 :trace
 [[clojure.lang.RT seqFrom "RT.java" 557]
  [clojure.lang.RT seq "RT.java" 537]
  [clojure.core$seq__5402 invokeStatic "core.clj" 137]
  [clojure.core.protocols$seq_reduce invokeStatic "protocols.clj" 24]
  [clojure.core.protocols$fn__8136 invokeStatic "protocols.clj" 75]
  [clojure.core.protocols$fn__8136 invoke "protocols.clj" 75]
  [clojure.core.protocols$fn__8088$G__8083__8101 invoke "protocols.clj" 13]
  [clojure.core$transduce invokeStatic "core.clj" 6884]
  [clojure.core$into invokeStatic "core.clj" 6899]
  [clojure.core$into invoke "core.clj" 6887]
  [edn_query_language.core$query__GT_ast invokeStatic "core.cljc" 302]
  [edn_query_language.core$query__GT_ast invoke "core.cljc" 295]
  [com.wsscode.pathom.core$join_seq_parallel$fn__18611$state_machine__8483__auto____18624$fn__18627 invoke "core.cljc" 436]
  [com.wsscode.pathom.core$join_seq_parallel$fn__18611$state_machine__8483__auto____18624 invoke "core.cljc" 432]
  [clojure.core.async.impl.ioc_macros$run_state_machine invokeStatic "ioc_macros.clj" 973]
  [clojure.core.async.impl.ioc_macros$run_state_machine invoke "ioc_macros.clj" 972]
  [clojure.core.async.impl.ioc_macros$run_state_machine_wrapped invokeStatic "ioc_macros.clj" 977]
  [clojure.core.async.impl.ioc_macros$run_state_machine_wrapped invoke "ioc_macros.clj" 975]
  [com.wsscode.pathom.core$join_seq_parallel$fn__18611 invoke "core.cljc" 432]
  [clojure.lang.AFn run "AFn.java" 22]
  [java.util.concurrent.ThreadPoolExecutor runWorker "ThreadPoolExecutor.java" 1128]
  [java.util.concurrent.ThreadPoolExecutor$Worker run "ThreadPoolExecutor.java" 628]
  [clojure.core.async.impl.concurrent$counted_t

Björn Ebbinghaus20:12:20

Ok. Transit is trying to encode the Exception. I was confused.

Björn Ebbinghaus20:12:15

I suspect that I'm the murderer...

wilkerlucio20:12:46

sorry, just looking at the stack I'm not sure whats going on, but if you can give me a small reproduction case I can debug it out

wilkerlucio20:12:19

it works if you use unbounded recursion?

Björn Ebbinghaus21:12:18

Yes. Sorry, that I did not reply. I have some problems getting the simplest resolver to run in the repl..

Björn Ebbinghaus21:12:26

I forgot the reader... 😓 My example works like intended...

Björn Ebbinghaus22:12:51

Ah! Got it! @wilkerlucio The Bug only appears with the parallel-parser. The serial parser works fine.

Björn Ebbinghaus22:12:20

And it also only happens when I do a to-many join

wilkerlucio13:12:32

cool, thanks! I'll take a look later today

Björn Ebbinghaus12:12:30

I opened an issue so that this is not being swallowed by Slack. https://github.com/wilkerlucio/pathom/issues/132

👍 4