you mean ::pc/batch? true?

Yes, sorry!

It seemingly only applies to the first item in the batched response

interesting, yeah, please open an issue, that's not intended

Okay! Also, thanks for your response on https://github.com/wilkerlucio/pathom/pull/88 - still waiting for a bit more clarification but happy to help if I can!

comment replied 😉

I guess I did replied already, I'm missing some other comment?

No, sorry, I just figured it might be faster to discuss on Slack. Specifically, won’t just adding it to the cache-batch function only make param caching work for batch requests? Also, won’t that mean that if it was resolved in a non-batch fashion earlier, it won’t be used if its later resolved in a batch? ie. Won’t one of them use params, and one of them not?

(And I’m totally happy to implement it that way, I just want to make sure that you’re okay with that, and that I’m not misunderstanding this code so that I can help more in the future 🙂 )

I mean, I replied on Github, did you saw that there? I'm confused on which point of the discussion you are

I saw! And again, sorry, I must be missing something

https://github.com/wilkerlucio/pathom/blob/dc0ff004ae887e94ae2085df027c43a148b352de/src/com/wsscode/pathom/connect.cljc#L950

Consider that line - isn’t that necessary such that the parameters get considered (and not collide) so that the inner body is even run a second time?

ok, I may understand now, so yes, for the cached-async calls you need to send p

is that what you pointing to?

Yes

cool, that's right, those calls still need p, my suggestion will be to remove from cache-batch and its calls

sounds good?

Okay! Will do!

Ready for re-review when you are! Thanks again for the responses.

thanks! I did a quick look and seems good, I wanna do some manual checks, probably some time during this week and then we can get it in, thanks for the work!