Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2018-02-12

Channels

#parinfer
<
2018-02-12
>
shaunlebron18:02:16

added some early thoughts for trying parinfer in Bruce’s new readline library: https://github.com/bhauman/rebel-readline/issues/84

shaunlebron18:02:57

parinfer-jvm will have to be updated

shaunlebron18:02:49

which is cool, because Timothy’s parinfer-based code validator will need it too: https://github.com/timothypratley/parsnip

cfleming21:02:05

The reaction to parinfer smart mode in Cursive can be fairly described as “rapturous”

shaunlebron21:02:33

you getting this feedback in the #cursive channel or elsewhere?

cfleming21:02:14

A bit by email, some here (mostly DMs), some on Twitter

cfleming21:02:23

But people really seem to like it.

cfleming21:02:44

@shaunlebron Did you get a chance to play around with the incorrect indentation marking? Any opinions on that?

shaunlebron21:02:01

Nice feedback! I wonder how many are trying it out. What would make you comfortable deploying it on next release?

shaunlebron21:02:08

Pulling up Cursive now to play with the markers. My only issue with it in theory is that wrong indentation anywhere in the file will prevent Parinfer from working everywhere in the file

cfleming21:02:22

Right, that’s the one thing I’d really like to fix. The user should be able to fix it themselves by just reformatting the file, of course.

cfleming21:02:52

And I like that they have to do it manually - that means that their files don’t get reformatted just by looking at them.

taylor21:02:24

This is what turned some of my coworkers off from using Parinfer originally. They had a lot of poorly formatted/indented files and just opening them would rearrange and sometimes break things.

cfleming21:02:40

Yeah, this has annoyed me too. In a lot of my tests, I used to leave a dangling close paren at the end of my deftests, because it made it easier to copy assertions per line.

cfleming21:02:06

Ironically of course, parinfer makes that more or less obsolete, but it’s still annoying to have a bunch of changes every time I look at a test file.

shaunlebron21:02:30

@U3DAE8HMG: it’s one thing for it to annoy, but yeah, it should never break. that was a problem with a race condition in intellij I believe

cfleming21:02:54

Right, breaking is a bug, the reformatting is just a bit annoying.

taylor21:02:18

FWIW this was like over a year ago, not sure what has changed in main-line Cursive+Parinfer since

taylor21:02:28

I’ve been happily using Cursive+Parinfer the whole time 🙂

cfleming21:02:28

Essentially nothing, sadly.

cfleming21:02:20

I’m going to investigate the “apply per top level form” change. If I can get that working then this will definitely become the next release right away. But honestly even without that this is still a vast improvement over what’s there anyway.

seancorfield21:02:29

And what's the plan for atom-parinfer in terms of this new release? (I'm not even sure who is responsible for cutting releases of that)

shaunlebron21:02:08

I’ll leave my feedback in #cursive

shaunlebron22:02:58

@seancorfield i’m maintaining atom-parinfer for smart mode things, but chris is still the gatekeeper on releases

shaunlebron22:02:35

feedback on atom-parinfer has been silent, except for your feedback sean. I still need to fix this: https://github.com/oakmac/atom-parinfer/issues/100

seancorfield22:02:47

Okay. Thanks for the clarification on releases.