@chrisoakman: Heads up, some big changes to code organisation in parinfer-jvm

It all uses Gradle now and is in a single module, which avoids needing to install to run the unit tests.

Running the perf tests is slightly ugly, but other than that it’s a good change.

I’m getting some failures trying to run the tests on parinfer (JS):

Returning changed lines
    1) indent mode: single change
    2) indent mode: multiple changes
    3) paren mode: single change
    4) paren mode: multiple changes


  67 passing (33ms)
  4 failing

  1) Returning changed lines indent mode: single change:
     TypeError: undefined is not a function
      at checkLines (test/extras.js:37:10)
      at Context.<anonymous> (test/extras.js:41:51)

  2) Returning changed lines indent mode: multiple changes:
     TypeError: undefined is not a function
      at checkLines (test/extras.js:37:10)
      at Context.<anonymous> (test/extras.js:42:51)

  3) Returning changed lines paren mode: single change:
     TypeError: undefined is not a function
      at checkLines (test/extras.js:37:10)
      at Context.<anonymous> (test/extras.js:44:51)

  4) Returning changed lines paren mode: multiple changes:
     TypeError: undefined is not a function
      at checkLines (test/extras.js:37:10)
      at Context.<anonymous> (test/extras.js:45:51)



npm ERR! Test failed.  See above for more details.
~/d/p/lib (master)> git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working directory clean
~/d/p/lib (master)>

parinfer 1.6.1 published, fixes the bug that @sekao reported

@cfleming: thanks for report, looks like a node version problem

assert.deepStrictEqual probably wasn’t available in older versions

I’m running node v5.2, locally and on travis-ci

@shaunlebron: Looks like that was it, thanks - an upgrade and some faffing around later and it’s working.

I’m 100% node illiterate

well, it’s the infamous JS error undefined is not a function that only becomes clear after years of seeing it

🤕

luckily v8 solved that in chrome a year ago and I think node v4 might have it, and v5 definitely does.

$ node
> var x = {}
undefined
> x.foo()
TypeError: x.foo is not a function

This seems relevant: https://pbs.twimg.com/media/Cbh6dV7UUAAVZ-y.png