Fork me on GitHub
#onyx
<
2018-07-01
>
lmergen11:07:17

@dave.dixon i think Onyx upgraded ZK (specifically, curator)to a more recent version in 0.13, but there were some issues with curator-test which was left on the old version

lmergen11:07:49

i'm using the latest version of curator/ZK myself (because I need a recent guava) and haven't experienced any issues so far

sparkofreason14:07:16

@lmergen Thanks. Do you know what version of ZK server you're running?

sparkofreason14:07:17

Interesting. I'll poke around in the deps analysis and see if something else might be interfering. I'll also give 3.3.6 a try if I can.

sparkofreason16:07:07

Onyx won't start at all with ZK 3.3.6, just hangs when trying to connect.

sparkofreason16:07:56

The version of Kafka I'm running also seemed to have trouble with 3.3.6.

lucasbradstreet17:07:07

@lmergen did you mean 3.3.6? That’s really old, but you say you’re using the latest version of ZK?

lmergen17:07:04

hmmm I’m using the latest tag on docker

lmergen17:07:32

oops, i read it wrong indeed

lmergen17:07:51

3.4.12 it is

lucasbradstreet17:07:38

I wonder if the issue is something to do with curator test and resolution with tools-dep then

lucasbradstreet17:07:01

Maybe we need some instructions to switch everything over together with exclusions, or just force users to provide both. Dependencies with zk and kafka can be tough with all of the versions floating out there in prod deployments

lmergen17:07:25

don’t forget about us poor google cloud users :)

lmergen17:07:37

i still need to override guava

lucasbradstreet18:07:22

How’s it working out for you?

lmergen18:07:05

good! running stable since release, 3 node cluster

lucasbradstreet18:07:33

At some point we can bring it into the official onyx org, and give you commit access. That is, assuming you’re interested.

lmergen18:07:16

yes would be good, i would like to make a few more changes in usability before that

lmergen18:07:50

there are some things regarding authentication i would like to improve

lucasbradstreet18:07:03

Great. Yeah, better to wait until you’ve iterated on it enough :)

sparkofreason18:07:06

@lmergen Are you using onyx-kafka, or the kafka-clients lib?

lmergen18:07:27

not using kafka

lmergen18:07:04

@lucasbradstreet exactly, i’ll give you a nudge when i think it’s fully stable.

sparkofreason18:07:08

Got it working after excluding ZK enough places and referring 3.4.12.

lucasbradstreet18:07:02

Great. That was what I was about to suggest once I saw “unknown type 15” in the logs and did some googling

lucasbradstreet18:07:18

It’d be helpful to know which libs you needed to exclude it from - especially anything we can improve on our side.

lmergen18:07:21

on that note, @lucasbradstreet -- would it be possible to move curator-test to the :test profile? or is this related to the onyx-test-env ?

lucasbradstreet18:07:36

Yeah, I think that’s a good idea. I’ve been hesitant about breaking user code but I think it probably has to be done

lucasbradstreet18:07:00

I have some backlog work to do with migrating all our projects to circleci 2, but if you want to send us a PR after doing a little testing I’d appreciate it

sparkofreason19:07:27

I'll try and figure out the minimal exclusions.