onyx-sql 0.11.1.0 seems to be missing :onyx.plugin.sql/read-rows-calls. Is this a known issue? Is onyx-sql not ready for use at this moment, as per this comment: https://github.com/onyx-platform/onyx-examples/blob/0.11.x/datomic-mysql-transfer/src/datomic_mysql_transfer/core.clj#L14 ?

@pithyless i've been using onyx-sql in production with pgsql for quite some time, it's stable -- not sure about that comment, though

@lmergen - which version of onyx-sql and onyx-platform are you running in production?

0.10

which is fairly similar to 0.11

the plugin has been refactored quite a lot between 0.9 and 0.10 upgrade, in which the read-row-calls were removed (the new plugin is much simpler, they were not needed anymore)

afaik write-row-calls are not needed either anymore, but for some reason they were not removed

onyx.tasks.sql/read-rows references a lifecycle :onyx.plugin.sql/read-rows-calls

interesting, that should be removed

https://github.com/onyx-platform/onyx-sql/blob/0.11.x/src/onyx/tasks/sql.clj#L110-L111

yeah i saw it

I am correct in understanding that add-task is the now preferred way of running jobs in onyx, correct?

it's a utility function that makes things a bit easier yes, but it's not required

I’m very new to all this; I got a gist of onyx from learn-onyx repo, but I do prefer the streamlined tasks approach to minimizing catalog boilerplate.

it's a lot of ground to cover

in that case, do use the add-task function, it's more clear and does some additional validation

thanks for the pointers @lmergen. I gutted onyx.tasks.sql/read-rows with my own version and moved forward. I’m sure I’ll be back with more questions 🙂

@pithyless Thanks, yes that looks like a bug. Ill axe it when Im back at my desk. 🙂