Fork me on GitHub
#onyx
<
2017-07-12
>
fellows17:07:03

Has anyone seen issues with :trigger/emit? I'm running Onyx 0.10.0, and I see the following exception when I use :trigger/emit, but not with :trigger/sync

Unfreezable type: class
   onyx.refinements$discarding_create_state_update
   {:type onyx.refinements$discarding_create_state_update, :as-str "#function[onyx.refinements/discarding-create-state-update]", :original-exception :clojure.lang.ExceptionInfo}

lucasbradstreet18:07:59

@fellows I haven’t seen that one. Using trigger/emit with the discarding refinement?

lucasbradstreet18:07:38

do you think you could try to reproduce it in that test?

fellows18:07:12

Thanks. I'll give it a try.

fellows22:07:28

@lucasbradstreet -- I'm unable to repro that error running that test in conjunction with my project and config settings. But, I can reproduce the error if I start with lein new onyx-app <name>, change the onyx version to "0.10.0", and add use the following window and trigger settings.

fellows22:07:09

(when running the basic-test)

lucasbradstreet22:07:18

@fellows thanks. If you created a new project would you mind pushing up the fresh project to github? No worries if not, but it'd make my life a little easier

fellows22:07:38

Hmm, it appears my corp network won't let me do that...

lucasbradstreet22:07:07

Ah, no worries then. Should be easy enough anyway. Thanks!

fellows22:07:46

I might be able to zip it and upload it here

lucasbradstreet22:07:35

that would be perfect

fellows22:07:34

There you go

fellows22:07:46

thanks for taking a look

lucasbradstreet22:07:13

@fellows oh, it’s because you’re trying to return the window-data arg which is basically a lot of metadata about the event. Unfortunately that record includes a lot of extra stuff that isn’t serializable, such as the refinement fn

fellows22:07:37

Argh. I was afraid it was something dumb like that. Thanks a lot for looking at it.

lucasbradstreet22:07:51

No worries, it’d be nice if we checked for that but validating on every submit would cost a lot perf wise.