Fork me on GitHub
#onyx
<
2017-06-02
>
lucasbradstreet01:06:05

@lmergen do you have the kafka lifecycles as part of your job? e.g.

{:lifecycle/task :read-messages
 :lifecycle/calls :onyx.plugin.kafka/read-messages-calls}

lmergen04:06:40

@lucasbradstreet no i dont have any lifecycles at all

lmergen04:06:54

i need to add them manually ?

lucasbradstreet04:06:00

you need the lifecycles described in the README, yep.

lucasbradstreet04:06:33

otherwise it won’t call handle-exception to decide whether to restart or kill the job, and will just default to kill

lucasbradstreet04:06:40

default kill is the default error handling

lmergen04:06:43

then i apologize for not rtfm'ing :)

lucasbradstreet04:06:16

in the past the plugin wouldn’t have worked at all, but more of the logic is in the plugin start/stop now

lmergen04:06:58

thanks for figuring this one out :)

lucasbradstreet04:06:10

no worries. Glad it’s not a bug in onyx. I remembered that we had a bug in our custom handle-exception lifecycle previously, which is why we saw the same thing.

lmergen04:06:57

that makes sense.