@aaelony Might've needed a lein clean to fix that -- Clojure version didn't have any affect on it.

likely right, though I had lein cleaned a few times as well.

@lucasbradstreet @smw About adding a new task map parameter to support functions that take the entire batch of segments as an argument, I think @lucasbradstreet's idea was right the first time. Let's deprecate :onyx/bulk? and introduce :onyx/batch-fn?. This is a much better replacement so long as the return value of a fn with :batch-fn? true is a vector than can either be a segment or a vector of segments. That'll cover it 1-1.

Cool, I think the side effect use case of :onyx/bulk? is handled by just splitting to two tasks anyway (split to the batch-fn? task, and the task that it would have flowed on to after)

Hm? I don't follow that. I believe you'll get the same effect as bulk? by simply returning the original args.

Yeah, sorry, that’s true too

Cool, I agree that deprecating bulk is the way to go

Let's move forward with that then, unless someone has a better name than :onyx/batch-fn?. We considered :onyx/batch?, :onyx/coalesce and :onyx-batched-args?

@michaeldrogalis I don’t like any of those, maybe :onyx/fn-batch?, but probably not

Wasn't batch-fn? your idea? Heh.

I mean any other than batch-fn?

Oh. Yeah, Im alright with batch-fn?

Cool, done

We will need to update the User Guide and learn-onyx. There's a challenge using :bulk? in there.

Didn’t think of that one

Good one

Ill take care of updating learn-onyx when it's ready to go.