Fork me on GitHub
#onyx
<
2016-07-07
>
Chris O’Donnell15:07:45

There's a minor typo at https://github.com/onyx-platform/learn-onyx/blob/master/test/workshop/jobs/challenge_6_0_test.clj#L38 (coordindate -> coordinate). This learn onyx repo is really fantastic, by the way.

devth15:07:16

codonnell: fix it and open a PR 🙂

Chris O’Donnell15:07:27

No problem. I found a couple more; I'll submit a new PR when I'm done working on this that has everything I found.

michaeldrogalis16:07:09

Awesome, it's appreciated. ^^

Chris O’Donnell16:07:49

All done, and submitted new PR. On a side note, :onyx.windowing.aggregation/average seems to maintain the state as a map with three keys, :n, :sum, :average, while the documentation only mentions :n and :average.

michaeldrogalis17:07:51

@codonnell: Thanks. Will patch up the docs in core later today.