Fork me on GitHub
#onyx
<
2016-01-27
>
robert-stuttaford04:01:29

wow. we haven’t even got done testing with 0.8.4. you guys rock!

lucasbradstreet08:01:36

@robert-stuttaford: it's really only one version as we had to rerelease because of an issue with 1.8

robert-stuttaford09:01:34

sorry, i meant about your changes in 0.8.5 simple_smile

lucasbradstreet09:01:41

Hehe, just meant that you're not truly 2 versions behind ;)

lucasbradstreet09:01:50

Big release though :)

mccraigmccraig12:01:56

@lucasbradstreet: when i use :onyx/restart-pref-fn would it be reasonable to build in a few seconds sleep to the restart-pred-fn ?

lucasbradstreet12:01:09

@mccraigmccraig: yeah, that might be a good idea to reduce churn

mccraigmccraig12:01:16

cool - that's all working then - awesome support @lucasbradstreet 😄

lucasbradstreet12:01:24

Great. Btw, it should fix the original cause but not whatever issue caused it to not work when you submitted a new job.

mccraigmccraig12:01:25

yeah, i'll see if that happens again - that's as likely to have been caused by me messing around as by an onyx problem

mccraigmccraig12:01:11

@lucasbradstreet: one other thing is there any reason not to just return true from the restart-pred-fn, given that i pretty much want my input tasks to pick themselves up whatever happens...

lucasbradstreet13:01:24

Not really. Cognician returns true from all of their tasks. For long running prod jobs it's what I'd recommend. Then I'd make sure monitoring is up to scratch. If you see an issue, kill the job and start a new one

lucasbradstreet13:01:26

@mccraigmccraig: just a heads up - we’ll be deprecating restart-pred-fn in a future release, but it should be super easy to translate to our new method. It’s basically just a lifecycle fn rather than a task-map option

lucasbradstreet13:01:46

We’re currently making it solid, which is why I don’t recommend it yet

mccraigmccraig13:01:59

yeah, i saw the GH issue about that

lucasbradstreet15:01:33

@robert-stuttaford: onyx-datomic 0.8.6.1 has been released with a bug fix similar to the kafka one I fixed for @mccraigmccraig