This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-04-14
Channels
- # beginners (53)
- # boot (93)
- # cider (13)
- # cljs-dev (17)
- # cljsrn (20)
- # clojars (1)
- # clojure (349)
- # clojure-austin (1)
- # clojure-gamedev (5)
- # clojure-italy (1)
- # clojure-nl (16)
- # clojure-poland (1)
- # clojure-russia (26)
- # clojure-spec (57)
- # clojure-uk (6)
- # clojurebridge (5)
- # clojurescript (145)
- # code-reviews (2)
- # core-async (88)
- # cursive (1)
- # datomic (3)
- # defnpodcast (10)
- # events (7)
- # hoplon (20)
- # instaparse (1)
- # jobs-discuss (15)
- # keechma (26)
- # lein-figwheel (2)
- # leiningen (1)
- # liberator (11)
- # lumo (40)
- # off-topic (54)
- # om (32)
- # onyx (11)
- # pedestal (6)
- # perun (4)
- # planck (6)
- # re-frame (4)
- # reagent (12)
- # ring (3)
- # ring-swagger (10)
- # rum (1)
- # testing (4)
- # timbre (1)
- # unrepl (20)
- # untangled (111)
- # vim (1)
@anmonteiro It appears to me that the compassus parser, for remote reads (that is, with a target), returns not a query but a single-element vector containing the query. Is that a known issue?
@peeja doesn’t break Om because we wrap send
https://github.com/compassus/compassus/blob/master/src/main/compassus/core.cljc#L289
do you need a different behavior?
@peeja so we previously had expr->ast
in the parser
but you noticed that wasn’t the right behavior 🙂
I don’t recall what the problem was exactly
I know we fixed it here https://github.com/compassus/compassus/commit/8db377181842674334914ccf51fba0ab94e271c0
oh right, we were doing (expr->ast (first ret))
thus ignoring (rest ret)
I don’t see any easy fix
@peeja PR welcome if you know how it should be fixed
Hmm. Do we have some guarantee that :compassus.core/mixin-data
and :compassus.core/route-data
won't be read at the same time?
I think they could?
when you’re re-rendering from root
@anmonteiro So, if I'm reading this right, if :compassus.core/mixin-data
and :compassus.core/route-data
are read at the same time, the result of the parser will be a vector of two elements, one for each of those queries. Then wrap-send
will concatenate those queries into a single query, and that's what'll go to the send
.
I'm not sure what the best way to deal with that is, but that's a potential issue that exists today.
I think that’s fair
@peeja thanks. I’ll review during the weekend