Fork me on GitHub
#om
<
2017-02-21
>
craigmalone00:02:53

@anmonteiro I have updated, reducing to just three components (Root, Child1, Child2) and all code now in core.cljs.

anmonteiro00:02:09

great, thanks

petterik05:02:51

@anmonteiro I narrowed down the react warning I was getting to a & character in a value in my :style map

petterik05:02:02

Created an issue and submitted a pr

anmonteiro05:02:06

I just commented on your PR 馃檪

anmonteiro05:02:14

I think it looks good, if that's what React also does

petterik05:02:24

Yeah, seems like it

anmonteiro05:02:29

(which by the looks of it is what seems likely)

anmonteiro05:02:12

@petterik awesome. did you submit your CA?

anmonteiro05:02:49

cool. Looks good to me, let's wait for David to check the CA thing

anmonteiro21:02:19

@dnolen if you have time to have a look today, #852 is good to go if @petterik has submitted his CA

anmonteiro21:02:29

also, can we get a release after that and #844 get in?

dnolen21:02:49

@anmonteiro will try but might have to wait to Friday

dnolen21:02:55

but I promise no later than Friday 馃檪

anmonteiro21:02:07

Friday鈥檚 good, no rush