Fork me on GitHub
#om
<
2016-10-23
>
tobiash12:10:41

i have a query like :prop1 :prop2] and the same read fn for both them, returning `{:remote true} for both props

tobiash12:10:01

both read functions are called, but my send function only gets called with the :prop1

tobiash13:10:36

where in the om source is the send function actually called?

anmonteiro14:10:01

@molstt sorry your example is just too conflated. you need to clarify what you want to do with a smaller example

anmonteiro14:10:16

I just don’t have time to look at everything and figure out what you want to do

anmonteiro14:10:02

one thing i noticed which is where you might want to start tracking what the problem is: in your parser the query you’ll get is a map of {:route query-for-that-route}

anmonteiro14:10:09

you don’t want to recurse on the entire thing

anmonteiro14:10:20

you probably want to extract the query-for-that-route and recurse on that

anmonteiro14:10:37

in my snippet, I think we want different behavior for that last example, right?

dnolen14:10:22

@anmonteiro ok, but will have too look at that later - prepping for travel

anmonteiro14:10:49

@dnolen definitely. safe travels!

anmonteiro14:10:36

FWIW it doesn’t break any other tests if we fix it. I’ll submit a PR for you to review whenever you’ve got time

alasdair15:10:17

Does db->tree expect collections to be either vectors or maps? (a scan of the code suggests it does). I.e. you cannot do a join on a set.

jfntn17:10:58

@anmonteiro the fix for om-808 seems to have solved my issues, but I’m now running into an error when the reconciler is trying to update a component deep inside a hierarchy. reconcile! invokes full-query with a nested component which throws a message like No queries exist for component path (compassus.core/ui_64283 <…my component hierarchy…>. Not sure where to start narrowing this down!

jfntn17:10:07

I should point out the component in question does implement IQuery, seems more like a path issue?

tony.kay17:10:53

@jonsmock the tutorial needs a new maintainer. I'm busy maintaining Untangled, which has it's own expanded version of that tutorial targeted at the plumbing we've written for Om Next. Be glad to merge PRs from anyone wanting to update it.

jonsmock19:10:12

@tony.kay: Thanks! I'm just getting back up to speed, but I'll send something if I can. Love the untangled work btw

tony.kay19:10:48

welcome, and thanks

anmonteiro19:10:35

Folks using Compassus: I’m in the process of fixing a lot of stuff which will mean some breaking changes. However, I keep a very detailed change log, so I foresee a very smooth upgrade path. Also, because I’m confident on the maturity of the library, once these changes are in place I’m just going to call the next release 1.0.0-alpha1

anmonteiro19:10:42

Feedback appreciated!

anmonteiro19:10:57

@jfntn if that’s a Compassus issue it would be great to include in these ^

anmonteiro19:10:04

do you have a minimal repro?

anmonteiro21:10:31

OK just released Compassus 1.0.0-alpha1 🎉 Check the change log’s “BREAKING” changes for information on how to upgrade, and feel free to ask me anything here or provide any feedback you might have! https://github.com/compassus/compassus/blob/master/CHANGELOG.md#100-alpha1-2016-10-23