Fork me on GitHub
#om
<
2016-09-24
>
nowprovision09:09:09

Just reading om-next considering for a CRM as a SPA. Is normalization an ongoing process? e.g. if server pushes more data to client? Do I even want Om to do normalization when working with a remote store?

peeja16:09:42

@nowprovision That's right: when you merge novel data into the app, the data will be normalized for you (if you have normalization on)

peeja16:09:24

Since it's optional, I'd say play with it, and see if it makes sense for you. It's more solid than you might think.

peeja16:09:29

For the most part, it just works.

anmonteiro16:09:19

@peeja FYI currently working on fixing your set-query! bug

peeja16:09:32

Sweet! Thanks!

peeja16:09:48

@anmonteiro Ah, that makes sense. Thank you!

anmonteiro16:09:44

this change could eventually lead to dropping some useless code in the monster that is build-index

anmonteiro16:09:54

I just don’t have time to look into that right now

peeja17:09:46

@anmonteiro I had a thought earlier this week: rather than use two mixins to set the query and build a wrapper, why not use the query from the wrapper component?

anmonteiro17:09:20

@peeja because the wrapper component sits between the root component and the component of the current route

peeja17:09:26

Ah, but it doesn't have to

anmonteiro17:09:27

there would be no way to compose those queries

anmonteiro17:09:45

I think it does

peeja17:09:53

That's only because the wrapper currently receives the factory and the route's props, and it puts them together

peeja17:09:23

If Compassus built the route component itself and passed the component into the wrapper, it would work

peeja17:09:35

The wrapper and the route component would both be children of the root

anmonteiro17:09:11

that might work

anmonteiro17:09:56

@peeja I have to look into that, mind opening an issue so I don’t forget?

anmonteiro17:09:06

awesome, thanks!

grzm20:09:30

For development of om itself, should bin/test always pass? I'm getting a compilation error on a fresh checkout

/Users/grzm/Documents/dev/om-dev/om/target/test/out/om/next/tests.js:696
return cljs.core._conj(cljs.core.Lisreturn cljs.core._conj(clj})(),new cljs.core.Symbol(null,"not","not",1044554643,null)),new cljs.core.Keyword(null,"message","message",-406056002),null], null));
                                 ^^^^^^^^^

SyntaxError: missing ) after argument list
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at global.CLOSURE_IMPORT_SCRIPT (/Users/grzm/Documents/dev/om-dev/om/target/test/out/goog/bootstrap/nodejs.js:75:3)
    at Object.goog.importScript_ (/Users/grzm/Documents/dev/om-dev/om/target/test/out/goog/base.js:907:9)
    at Object.goog.writeScripts_ (/Users/grzm/Documents/dev/om-dev/om/target/test/out/goog/base.js:1420:16)

anmonteiro20:09:28

@grzm weird getting that too

anmonteiro20:09:36

I normally just run boot test these days

grzm20:09:00

I'm glad it's not just me 🙂

grzm20:09:10

Trying boot test now

grzm20:09:22

that worked fine. Thanks, @anmonteiro

grzm20:09:52

Has there been any consideration of adding om to Travis?

anmonteiro21:09:10

@grzm hrm, it’s running in CircleCI currently

anmonteiro21:09:17

is there a case to made for Travis?

grzm21:09:43

I wasn't aware it was in CircleCI. Is the current build status available? I guess it's passing boot test 🙂

grzm21:09:33

Nice! Would you accept a pull request to add a build status badge? https://circleci.com/gh/omcljs/om.svg?style=shield&amp;circle-token=:circle-token

anmonteiro21:09:03

I think there’s already one

grzm21:09:54

You're right 🙂