@ethangracer what's wrong with wrapping recharts in an OM object

just boilerplate?

pretty much, yeah

nothing wrong with it, just tedious if you want to do it for a large number of components

also @jasonjckn can’t use om/factory on non-om components

which makes me wonder if rendering a non-om component from a non-om factory would cause issues (indexer, reconciler, etc.)

well you could use (om/ui ... ) to wrap it

(defn react-to-om [react query ident] (om/ui IQuery (query [] query) Ident (ident [] ident) Object (render [] react )

hadn’t seen that function before

interesting

@anmonteiro: thoughts? ^^^

i this hack so that I don't have to create factories

(defmacro ui [q & forms]
  {:pre [(or (map? q) (vector? q) (list? q))]}

  `(let [factory-fn# (atom nil)

         new-ui# (om.next/ui
                     ~'static cljs.core/IDeref
                     (~'-deref [this#]
                      @factory-fn#)

                     ~'static om.next/IQuery
                     (~'query [this#]
                      ~q)

                     ~@forms)]

     (reset! factory-fn#
             (om.next/factory new-ui# {:keyfn admin.util/uid-gen}))

     new-ui#))

(def MyNewComp (ui ...) )

MyNewComp is the om/react class, then @MyNewComp to get the factory

interesting, I like that

@ethangracer I suppose that would work for the simplest case

However I fail to see a solution for e.g. children

How do you all typically get the “parent” value when implementing a field? For instance my friends-list would typically depend on the user in question.

if anyone is familiar with the graphql way, it would be like this:

new GraphQLObjectType({
  name: 'MyType',
  fields: {
    myField: {
      type: GraphQLString,
      resolve(parentValue, args, session) {
        // use `session` here
      }
    }
  }
});

parentValue is passed to resolve

@dankweaver Links would be the way to go https://github.com/omcljs/om/wiki/Thinking-With-Links%21

thank you so much

however it’s a bit of a different concept

it’s not really accessing the parent per se

but something that is “global” to the application

i.e. a top level property in your app state

hmm how does this work on remotes tho.. there wouldn’t be enough context would there?

links aren’t supposed to be sent to remotes

in my experience, you’d have :foo in a top-level query and send that to the remote

once it’s fetched, queries down in the component tree can have foo with [:foo _]

ahh

thank you.. this makes sense

implicit arguments like current user I suppose would just be in the env that is passed to read