Fork me on GitHub
#off-topic
<
2017-03-03
>
grav20:03:15

I just created a pull request on github, and was asked to make some changes to it, and cleaning up the commit log. I’m not that familiar with Git, so how do I re-do my commit when it’s already pushed, short of deleting my PR, creating a new fork and then re-doing the PR?

sbauer20:03:41

You could make the changes locally and then force push to your remote branch... the PR should be updated automagically after

sbauer20:03:18

Assuming you have a fork and the branch is on it then shouldn't be an issue with force pushing

grav20:03:01

I’ll try that out. It just seems odd to me that it won’t be inconsistent, since the current PR refers to the old commit?

grav20:03:31

Will the comments just show as outdated somehow?

sbauer20:03:56

Yes, I think that is the case

sbauer20:03:03

At least, it has been my experience

grav20:03:12

Cool, I’ll see what happens 🙂

7h3kk1d20:03:58

The pr refers to the branch name not the commit

7h3kk1d20:03:08

So as long as you push to the same branch it should be fine