Clojurians Log v2

Can you point us to the code you're currently using so we can advice you how to update it?

yes, it's in the message, but here's the link: https://github.com/ericdallo/metrepl/blob/480b5e387d015bc044f91bf2770f9925fff2afd5/src/metrepl/metrics.clj#L81

Hey folks, Just to add to what @ericdallo said. Also the cider-list-nrepl-middleware functionality in Emacs stops working with the alpha version

> I've added a field middleware to the describe op response, it fits well there and achieves the same thing. So, basically now we have to use the describe op for this info. I'll update CIDER soon. This had slipped my mind.

Nice to see someone besides me knows of cider-list-nrepl-middleware. 🙂

See https://github.com/nrepl/nrepl/blob/df91146d1021e1c54eef140bea4c63c9dd678685/src/clojure/nrepl/middleware.clj#L55

Hello folks, I am sorry that this actually breaking change messed up your middleware. I hope it wouldn't be much of a hurdle to support older and newer nREPL version for you – you can check nrepl.version/version in the code to make appropriate decisions.

But overall this is an effort to streamline things and reduce the API surface. We hope the end result will be beneficial rather than detrimental.

no problem, thank you for the quick reply! we will take a look and try the describe approach

The warning still appears in the release version.

Non cljs project. Zero reason to warn me about that.

WARNING: Middleware #'cider.piggieback/wrap-cljs-repl is required by #'cider.nrepl/wrap-complete but is not present in middleware list.

For example: I might have configured in nrepl.edn :

{:middleware ^:concat [metrepl/middleware]}

:repl {:main-opts ["-e" "(require,'ns1)" "-m" "nrepl.cmdline"  "--middleware" "[metrepl/middleware]"]}

Hey, good point, the deduplication is certainly necessary. Thanks for bringing this up.

Actually, I would suppose it is deduplicated by converting it to a set here https://github.com/nrepl/nrepl/blob/master/src/clojure/nrepl/middleware.clj#L95

Ah, I see now, it is not used later for iteration. Right.

To be completely sure I did the experiment and got this from the describe operation:

user> (require '[nrepl.core :as nrepl])
;; => nil
user> (defn check-middleware
  "Connect to an nREPL server and check for duplicate middleware.
   Takes a port number.
   Uses the ls-middleware op to get the current middleware stack."
  [port]
  (let [conn (nrepl/connect :port port)
        client (nrepl/client conn 1000)
        response (first (nrepl/message client {:op "describe"}))
        mw (:middleware response)]
    {:middleware mw
     :total (count mw)
     :unique (count (distinct mw))
     :duplicates? (not= (count mw) (count (distinct mw)))
     :duplicate-entries (->> (frequencies mw)
                             (filter #(> (val %) 1))
                             (into {}))}))
;; => #'user/check-middleware
user> (check-middleware 65326)
;; => {:middleware
 ["#'nrepl.middleware/wrap-describe"
  "#'nrepl.middleware.completion/wrap-completion"
  "#'nrepl.middleware.interruptible-eval/interruptible-eval"
  "#'"
  "#'nrepl.middleware.load-file/wrap-load-file"
  "#'nrepl.middleware.lookup/wrap-lookup"
  "#'nrepl.middleware.session/add-stdin"
  "#'cider.nrepl/wrap-apropos"
  "#'cider.nrepl/wrap-classpath"
  "#'cider.nrepl/wrap-clojuredocs"
  "#'cider.nrepl/wrap-complete"
  "#'cider.nrepl/wrap-content-type"
;; =>   "#'cider.nrepl/wrap-debug"
  "#'cider.nrepl/wrap-enlighten"
  "#'cider.nrepl/wrap-format"
  "#'cider.nrepl/wrap-info"
  "#'cider.nrepl/wrap-inspect"
  "#'cider.nrepl/wrap-log"
  "#'cider.nrepl/wrap-macroexpand"
  "#'cider.nrepl/wrap-ns"
  "#'cider.nrepl/wrap-out"
  "#'cider.nrepl/wrap-slurp"
  "#'cider.nrepl/wrap-profile"
  "#'cider.nrepl/wrap-refresh"
  "#'cider.nrepl/wrap-reload"
  "#'cider.nrepl/wrap-resource"
  "#'cider.nrepl/wrap-spec"
  "#'cider.nrepl/wrap-stacktrace"
  "#'cider.nrepl/wrap-test"
;; =>   "#'metrepl.middleware.tests-metrics/wrap-tests-metrics"
  "#'cider.nrepl/wrap-trace"
  "#'cider.nrepl/wrap-undef"
  "#'cider.nrepl/wrap-tracker"
  "#'cider.nrepl/wrap-version"
  "#'cider.nrepl/wrap-xref"
  "#'flow-storm.nrepl.middleware/wrap-flow-storm"
  "#'nrepl.middleware.caught/wrap-caught"
  "#'nrepl.middleware.print/wrap-print"
  "#'nrepl.middleware.session/session"
  "#'metrepl.middleware.op-metrics/wrap-op-metrics"
  "#'metrepl.middleware.op-metrics/wrap-op-metrics"
;; =>   "#'metrepl.middleware.tests-metrics/wrap-tests-metrics"
  "#'metrepl.middleware.op-metrics/wrap-op-metrics"
  "#'metrepl.middleware.tests-metrics/wrap-tests-metrics"
  "#'refactor-nrepl.middleware/wrap-refactor"],
 :total 45,
 :unique 41,
 :duplicates? true,
 :duplicate-entries
 {"#'metrepl.middleware.tests-metrics/wrap-tests-metrics" 3,
;; =>   "#'metrepl.middleware.op-metrics/wrap-op-metrics" 3}}
user> 

1.6.0-alpha2 just hit.

Thank you!

The transition from 1.5.2 to 1.6.0-alpha2 introduced a change that in my setup generates an error: Execution error (ExceptionInfo) at nrepl.middleware/extended-descriptors$iter$fn (middleware.clj:103). Middleware #'cider.piggieback/wrap-cljs-repl is required by #'cider.nrepl/wrap-complete but is not present in middleware list. My project is pure Clojure, not Clojurescript, so the reference to piggieback is suspect.

Hey, sorry for that, this alpha was not really intended to be rolled out to all users already, I'm rolling it back right now. But it will take a few hours to update on MELPA, so for the time being, please downgrade back to 1.5.2 by doing M-x customize-variable cider-injected-nrepl-version.

Sure, no problem at all. I am sorry in that case.

Thank you for your hard work.