Clojurians Log v2

context of generated dist/app.service.js file

what output did you see?

"it didn't work" is not very informative without elaborate error output or a repro that I could run locally

oh I see, the error is on the right, I'm sorry

yes, nbb is an ES6 project, your project should also be compiled as an ES6 project, but it's compiled as CJS project

right, i am trying to build with “cjs” type for nest.js however no success. will try few more things and add more details.

you can import nbb with a dynamic import though

from cjs

async function loadNbbFile(file) {
  const nbb = await import('nbb');
  await nbb.loadFile(file);
}

(async () => await loadNbbFile('hello.cljs'))();

that will be one way, i am trying now. https://dev.to/wolfejw86/the-commonjs-vs-es-modules-war-is-taxing-for-us-regular-folks-out-here-one-way-to-interop-55e tried this one and for some weird reason getting argument mismatch error even when it correct ( trying this further).

I don't think the const DynamicImport has any benefits over using dynamic import directly?

I mean, you can just write:

async myImport(module) {
  return import(module);
}

or even just import which is already a function

(await import('nbb')).default

(async () => console.log( (await import('nbb')) ))()

yes simple await will work, i was overlooking and missed the change in app.service.ts (that’s where argument count mismatch).

there is no default export in nbb, you need to use .loadString or whatever directly.

or just pass the whole nbb itself

either way, don't do .default , there is none on the nbb module

ok sure.

that also didn’t work... however it moved 1 step ahead and now control reached nestjs framework level and that threw same exception. Will try out few more things, if this works it will be great fun and easy migration to clojure stack :)

You still have import from 'nbb' on the right, this is causing the error

the top level import

^ @pradeep.bishnoi

tried removing it earlier (later only got that to pull the type) - retrying without that fully (it will require some change in app.service.ts constructor (i.e., line number 7)

loadFile is a function of string -> Promise<Any> if that helps

not sure, trying few combinations. Wouldn’t it be helpful if we add a default export to nbb package it self?

default exports aren't mandatory and I would say even an anti-pattern. there is no single thing that is "default" about the nbb API

never liked js eco-system (long live Java eco-system) and now this is adding more reasons to it.

perhaps typescript is trying to be clever and rewrites (await import('nbb').loadFile) to a top level import which then gets compiled as require. To work around this can you write:

async function myLoadFile(file) {
  const nbb = await import('nbb');
  return nbb.loadFile(file);
}

If that doesn't work, perhaps then I get why they used Function in the earlier example

let me try. and thanks for all the proactive help so far.

The const dynamicImport one I mean, perhaps TS is too clever and tries to optimize it when you don't write it using that

this time server started, one more step forward. however failing to load cljs while accessing the endpoint (locahost:3000).

ah yes, that's it:

For what it's worth, if we were in regular Javascript land this would work by itself, but wouldn't you know it, TypeScript has it's own problems with this one - it's actually rewriting that dynamic import as a require statement 😢. It's even sadder to realize that there's no way around this without hiding your dynamic import from the TypeScript compiler with a hackier method.

from that article you linked (https://dev.to/wolfejw86/the-commonjs-vs-es-modules-war-is-taxing-for-us-regular-folks-out-here-one-way-to-interop-55e)

yes, please use the const dynamicImport you head earlier, TS is rewriting dynamic import

or just use a freaking .js file - screw ts ;)

this is 1 more step forward. now no error in module loading however data from cljs file is not returned in the api response. can’t use .js as want to migrate some existing service with nestjs(typescript) to clj.

What is in your .cljs file?

(ns hello)

;; variation 1 tried
;; (defn someData []
;;   "Hi, please show up in api response")

;; variation 2 tried
(defn someData []
 {:a "Hi, please show up in api response"})

#js {:someData someData}

> however data from cljs file is not returned in the api response where are you calling the someData function then?

in the app.controller.ts the getHello function is getting called which is injected in the app.service.ts

i guess it might be because of promise type, will try without that.

changing (removed the promise, and made it only string) the return type of the getHello also didn’t help.

isn't what you're seeing here a JS object being printed?

you are returning a JS object from the loadFile call (async, so you might want to add an await in there)

just console.log it and it will hopefully become clear to you

What I mean is:

getHello(): Promise<string> {
  const loadFileResult = await this.loadFile("...");
  const { someData } = loadFileResult;
  const result = someData();
  console.log(result);
  return result;
}

The result of someData is not a string, but a CLJS map in your code, but hopefully you get the idea

yes, this piece of code worked for me. Thanks so much, you are awesome @borkdude gratitude-danke. Just relooking at organising it now for better usage.

cool :)