Fork me on GitHub
#minimallist2020-08-11
>
borkdude08:08:04

About your PR for :transform do you have any docs so I can read how it works? Why not something like (h/conformer (h/cat int? int?) (map inc))

Vincent Cantin11:08:48

@borkdude in the PR, there are some tests which are using the new transformer node via a new helper function.

Vincent Cantin11:08:38

I can write a doc once I go home later tonight. I myself like the new node and found a usecase in my Vrac project. I am interested to know if I should add more options in the node.

borkdude11:08:48

Thanks. I hope to take a look tomorrow

Vincent Cantin11:08:11

this one is an example with a data parsing

borkdude11:08:05

I actually took a look at that example, but didn't understand how that was useful: it has the same output as input?

Vincent Cantin11:08:52

because the functions are doing inverse transformations

borkdude11:08:28

that could just be accomplished using a predicate, so maybe not the best example?

Vincent Cantin11:08:29

inner model is sequence of things, from the outside it is a string

borkdude11:08:12

I could be missing something

Vincent Cantin11:08:31

a predicate alone could not leverage an inner model

borkdude11:08:07

This is why I'd like to see some docs: the tests alone don't explain enough to me. So I'll look again when you have those

borkdude11:08:44

I haven't used minimallist enough to be able to make sense of just code