membrane

zimablue 2023-03-25T17:22:07.943149Z

hey I've been using a branch I made a while back from commit 75d38cc which just AFAIR mostly made some changes in order to enable me to import membrane on the backend of an electron app (by IIRC testing whether it looks like we're in a node environment and then disabling the side-effecting-on-startup things which try to download fonts and do something with sound), that's from Jul 13 I see you've been active since then are there any big changes I should be aware of? Any good place to look for release notes etc? Circling back to do some more UI work for my app so first thing I'll do is try to manually rebase my modifications to your latest version

phronmophobic 2023-03-25T17:26:27.450409Z

I do try to write meaningful commit messages, but I haven't tried to keep any release notes.

phronmophobic 2023-03-25T17:26:54.918769Z

There's only been 3 commits that make changes to webgl.cljs since 75d38cc.

phronmophobic 2023-03-25T17:27:35.728389Z

I think the biggest one is just having an option to pass the container size to the view function, cdf30332d72806cc9fe8abb602d757590aa4b1c3

phronmophobic 2023-03-25T17:28:48.275719Z

> I also have things which are a bit like membrane patches but that live externally to your code, mostly what we discussed earlier around different meanings of origin/bounds (I added a top-left and bottom-right protocol to everything which function differently to origin and bounds) I've tried to make changes backwards compatible so I don't think there are any changes in membrane where your external patches would stop working.

phronmophobic 2023-03-25T17:30:43.200499Z

Most changes were adding new namespaces or functions. Looking back at all the commits, the biggest change that might affect you is some refactoring around defui.

zimablue 2023-03-25T17:31:22.095339Z

Changes to UI and component would impact me too

zimablue 2023-03-25T17:31:49.595399Z

Tha is of course I'm happy to read the source code but sometimes a two second description of the high level direction saves a lot of head scratches

zimablue 2023-03-25T17:32:10.365879Z

Sounds like it shouldn't be too painful then, thank for the guidance!

zimablue 2023-03-25T17:32:14.086829Z

Thanks*

phronmophobic 2023-03-25T17:33:15.726739Z

For defui, it was support for letting you pass non literal maps as args.

zimablue 2023-03-25T17:33:34.452229Z

Oh nice! I remember we had discussed that

zimablue 2023-03-25T17:34:18.641219Z

Do UI components as parameters work no without having to metadata-state their type for implicit params to work? How we discussed with textboxes

phronmophobic 2023-03-25T17:34:52.082659Z

No, that still works the same.

zimablue 2023-03-25T17:23:20.195079Z

I also have things which are a bit like membrane patches but that live externally to your code, mostly what we discussed earlier around different meanings of origin/bounds (I added a top-left and bottom-right protocol to everything which function differently to origin and bounds)